Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Outdated Cypress tests in 9_integrations #1039

Closed
Swiddis opened this issue Sep 21, 2023 · 1 comment · Fixed by #1242 or #1290
Closed

[BUG] Outdated Cypress tests in 9_integrations #1039

Swiddis opened this issue Sep 21, 2023 · 1 comment · Fixed by #1242 or #1290
Assignees
@Swiddis @RyanL1997
Labels
bug Something isn't working integrations Used to denote items related to the Integrations project maintenance

Comments

@Swiddis
Copy link
Collaborator

Swiddis commented Sep 21, 2023

What is the bug?
In the latest test run, 4/10 Cypress tests for integrations are failing due to the new set up UI.

How can one reproduce the bug?
CI action, also cypress tests locally.

What is the expected behavior?
The tests should pass.

What is your host/environment?

Do you have any screenshots?

Do you have any additional context?
Peter has talked a lot about implementing feature flags, that would be a good move here, so we can continue development without needing to comment out tests for a broken UI. It would allow future work to be better about making small PRs, too.
@Swiddis Swiddis added bug Something isn't working untriaged maintenance labels Sep 21, 2023
@Swiddis Swiddis self-assigned this Sep 21, 2023
@Swiddis Swiddis removed the untriaged label Sep 21, 2023
@Swiddis Swiddis mentioned this issue Sep 21, 2023
Closed
@Swiddis Swiddis mentioned this issue Nov 13, 2023
Merged
6 tasks
@Swiddis
Copy link
Collaborator Author

Swiddis commented Dec 6, 2023

Tests are broken again -- Community contribution added 2 more assets for 6, and the tests still expect 4.

@Swiddis Swiddis reopened this Dec 6, 2023
@Swiddis Swiddis added integrations Used to denote items related to the Integrations project and removed untriaged labels Dec 6, 2023
@RyanL1997 RyanL1997 mentioned this issue Dec 7, 2023
Merged
6 tasks
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this issue Apr 18, 2024
@opensearch-trigger-bot @devardee
Preserve URL Hash for SAML based login (opensearch-project#1039) (ope…
3a04a68 
…nsearch-project#1105)

* Preserve URL HASH after user logs via SAML IDP

Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com>
(cherry picked from commit a9d10d82f03aa759d3e51e841d7dbfcc28db5628)

Co-authored-by: Deepak Devarakonda <80896069+devardee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Swiddis Swiddis

@RyanL1997 RyanL1997

Labels
bug Something isn't working integrations Used to denote items related to the Integrations project maintenance
Projects
None yet
Milestone
No milestone
3 participants
@kavithacm @Swiddis @RyanL1997