Adds integration tests in the repo for customImportMap plugin #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsearch-project#29) Signed-off-by: Shivam Dhar <dhshivam@amazon.com> (cherry picked from commit e7cef5b) Co-authored-by: Shivam Dhar <dhshivam@amazon.com>
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #30 +/- ##
=======================================
Coverage 85.03% 85.03%
=======================================
Files 5 5
Lines 147 147
Branches 24 24
=======================================
Hits 125 125
Misses 16 16
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
7733513 to
c45d09f
Compare
CCongWang
reviewed
Aug 15, 2022
CCongWang
reviewed
Aug 17, 2022
src/plugins/custom_import_map/cypress/integration/geojson_file_upload.spec.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
4448b9c to
fbfc0db
Compare
CCongWang
approved these changes
Aug 17, 2022
VijayanB
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Thanks @Shivamdhar for making these changes and adding tests.
junqiu-lei
approved these changes
Aug 17, 2022
junqiu-lei
pushed a commit
to junqiu-lei/dashboards-maps
that referenced
this pull request
Apr 25, 2023
…ect#30) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
customImportMapDashboardspluginIssues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.