Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dashboards as suffix to plugin name #27

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

Shivamdhar
Copy link
Contributor

Signed-off-by: Shivam Dhar dhshivam@amazon.com

Description

  • To remain consistent with the other dashboards plugins, added suffix to plugin name
  • Also, added missing properties in package.json

Tested building the plugin zip -

yarn build
yarn run v1.22.18
$ yarn plugin-helpers build
$ node ../../scripts/plugin_helpers build
 info deleting the build and target directories
 info running @osd/optimizer
 │ info initialized, 0 bundles cached
 │ info starting worker [1 bundle]
 │ succ 1 bundles compiled successfully after 34.7 sec
 info copying assets from `public/assets` to build
 info copying server source into the build and converting with babel
 info running yarn to install dependencies
 info compressing plugin into [customImportMapDashboards-2.2.0.zip]
✨  Done in 44.34s.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
@Shivamdhar Shivamdhar requested a review from a team August 4, 2022 20:36
@Shivamdhar Shivamdhar self-assigned this Aug 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #27 (a13b9b6) into 2.x (b805924) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x      #27   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files           5        5           
  Lines         147      147           
  Branches       24       24           
=======================================
  Hits          125      125           
  Misses         16       16           
  Partials        6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Shivamdhar Shivamdhar merged commit e7cef5b into opensearch-project:2.x Aug 4, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 4, 2022
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
(cherry picked from commit e7cef5b)
Shivamdhar added a commit that referenced this pull request Aug 4, 2022
Signed-off-by: Shivam Dhar <dhshivam@amazon.com>
(cherry picked from commit e7cef5b)

Co-authored-by: Shivam Dhar <dhshivam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants