Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categorize search queries by type and log query shape #10502

Closed
wants to merge 89 commits into from
Closed

Categorize search queries by type and log query shape #10502

wants to merge 89 commits into from

Conversation

deshsidd
Copy link
Contributor

@deshsidd deshsidd commented Oct 9, 2023 •
edited
Loading

Description

Changes to categorize search queries based on the type of the query (eg: bool, match, multi-match, etc).
Changes also log the query shape of a query (queries can have a nested structure with a hierarchy of subqueries).

  • Use QueryShapeVisitor to debug log the shape of the queries. Example
  • Use QueryBuilderVisitor to visit all the nodes of the querybuilder tree for incoming search queries and increment counters to capture query type information
  • Integrate with Metric Framework for the counters

Related Issues

Resolves #10250

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change b2d7e67

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Gradle Check (Jenkins) Run Completed with:

gaobinlong and others added 23 commits October 18, 2023 16:57
@gaobinlong @dblock @deshsidd
Fix dissect ingest processor parsing empty brackets failed (opensearc…
3c71fed 
…h-project#9255)

* Fix dissect ingest processor parsing empty brackets failed

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Add assertion

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@Gaganjuneja @deshsidd
Add telemetry tracer/metric enable flag and integ test (opensearch-pr…
53b4bc0 
…oject#10395)

* Add telemetry tracer/metric enable flag and integ test

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add Changelog

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fix compilation issue

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add component flag to traceable wrappers

Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@mch2 @deshsidd
Fix flaky test testFlushThrowsFlushFailedExceptionOnCorruption. (open…
d90b6ec 
…search-project#10671)

This test is flaky in two ways, one it may hit a case where a merge occurs and the hardcoded segment does not exist to delete.
Two with certain mock filesystems a corruption exception won't be thrown here, only a NoSuchFile - This doesn't change our
handling in the engine, but the test should conditionally handle if the store is marked corrupted on close.

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@dhwanilpatel @deshsidd
Change filenames for IndexMetadata and Manifest (opensearch-project#1…
7cb87c0 
…0557)

* Change filenames for IndexMetadata and Manifest

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@linuxpi @deshsidd
revive remote cluster state auto restore integ tests (opensearch-proj…
b921942 
…ect#10503)

* revive remote cluster state auto restore integ tests

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@dhwanilpatel @deshsidd
:pload global cluster state to remote store (opensearch-project#10404)
16e75f3 
* Upload global cluster state to remote store

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@Rishikesh1159 @deshsidd
[Segment Replication] Unmute Test SegmentReplicationTargetServiceTest…
042ae20 
…s.testShardAlreadyReplicating (opensearch-project#10660)

* Remove Awaits fix.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* apply spotlesscheck.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* add test logging.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@vikasvb90 @deshsidd
Added BufferedInputStream to allow mark and reset ops during IO errors (
d79a6cc 
opensearch-project#10690)

Signed-off-by: vikasvb90 <vikasvb@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@Bukhtawar @deshsidd
Repository stats for remote store (opensearch-project#10567)
ffe24c3 
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
@stephen-crawford @deshsidd
OnBehalfOf claims take second duration (opensearch-project#10664)
4b33c59 
OnBehalfOf claims take second duration

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@kotwanikunal @deshsidd
Fix download reporting for segment replication (opensearch-project#10644
f3c6f8b 
)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@dhwanilpatel @deshsidd
Download functionality of global metadata from remote store (opensear…
611983a 
…ch-project#10535)

* Download funcationality of global metadata from remote store

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
@deshsidd
Build fix
d93f06b 
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@deshsidd
Fix build tests failure
f458ef2 
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@deshsidd
Empty commit
411164d 
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@linuxpi @deshsidd
Remote Restore Cluster Metadata if local disk state lost after quorum…
c56a532 
… loss recovery (opensearch-project#10447)

* Remote Restore Cluster Metadata if local disk state lost after quorum loss

Signed-off-by: bansvaru <bansvaru@amazon.com>
@gbbafna @deshsidd
Version fixes for Resource Usage Stats and FS Stats (opensearch-proje…
9ee6697 
…ct#10712)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@kotwanikunal @deshsidd
Add missing entry for 2.11 release notes (opensearch-project#10679)
e0a5244 
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@dzane17 @deshsidd
Per request phase latency (opensearch-project#10351)
f8f35ca 
Signed-off-by: David Zane <davizane@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@deshsidd
Empty commit
6b8e907 
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@deshsidd
Empty commit
35ae1d0 
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@deshsidd
Empty commit
5fcde3e 
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@deshsidd
Empty commit
8cfe2bf 
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@deshsidd deshsidd force-pushed the sid/search-query-category branch from b2d7e67 to 8cfe2bf Compare October 19, 2023 00:01
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@deshsidd deshsidd mentioned this pull request Oct 19, 2023
Merged
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@deshsidd deshsidd closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getsaurabh02 getsaurabh02 getsaurabh02 left review comments

@backslasht backslasht backslasht approved these changes

@Gaganjuneja Gaganjuneja Gaganjuneja approved these changes

@msfroh msfroh msfroh approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search Query Categorization (Phase 1)