Integ test fix -> Fix broken backward compatibility from 2.7 for IndexSorted field indices #10045

[gashutos]

While resolving one of comment, #10045 (comment)
I added shouldWidenIndexSortTpe as a class member and initialized from Settting.

But IndexSortConfig constructor is always getting called before IndexSettings determines the current version and put shouldWidenIndexSortTpe in their class. So shouldWidenIndexSortTpe always stayed false after that change and lead failuers in integ test org.opensearch.backwards.IndexingIT.testUpdateSnapshotStatus in 2.10 branch.

I am going to update this PR as well #10076

[gashutos]

Skipping changelog as related to this.
#10045

[gashutos]

@reta the fix for mixed cluster UT. Surprise it didnt fail in main but only on 2.x branches. I am updating 2.10 PR as well and that should be green

[reta]

@reta the fix for mixed cluster UT. Surprise it didnt fail in main but only on 2.x branches. I am updating 2.10 PR as well and that should be green

I think because mixed cluster uses 3.x and 2.11.x which do not have the widening problem, vs 1.3.x and 2.11.x which do

[gashutos]

@reta the fix for mixed cluster UT. Surprise it didnt fail in main but only on 2.x branches. I am updating 2.10 PR as well and that should be green

I think because mixed cluster uses 3.x and 2.11.x which do not have the widening problem, vs 1.3.x and 2.11.x which do

Ah, got it !!

[github-actions]

Compatibility status:

Checks if related components are compatible with change 65537bf

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.index.shard.RemoteIndexShardTests.testRepicaCleansUpOldCommitsWhenReceivingNew

• URL: https://build.ci.opensearch.org/job/gradle-check/25745/
• CommitID: 65537bf
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Merging #10087 (65537bf) into main (5fdd418) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main   #10087      +/-   ##
============================================
+ Coverage     71.09%   71.11%   +0.01%     
+ Complexity    58152    58098      -54     
============================================
  Files          4825     4825              
  Lines        274031   274032       +1     
  Branches      39930    39930              
============================================
+ Hits         194836   194890      +54     
+ Misses        62881    62780     -101     
- Partials      16314    16362      +48     

Files Changed	Coverage Δ
...ain/java/org/opensearch/index/IndexSortConfig.java	73.17% <0.00%> (-0.33%)	⬇️
...c/main/java/org/opensearch/index/IndexService.java	76.03% <100.00%> (+0.54%)	⬆️

... and 433 files with indirect coverage changes

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10087-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d7aa6dd9c7759bbfedd7263d453d3ac6c92fab7d
# Push it to GitHub
git push --set-upstream origin backport/backport-10087-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-10087-to-2.x.

[gashutos]

I will raise seperate PR for backport of 2.x, clubbing with #10075

[reta]

I will raise seperate PR for backport of 2.x, clubbing with #10075

Let me cherry pick