[Backport 2.10] Fix broken backward compatibility from 2.7 for IndexSorted field indi… #10076

gashutos · 2023-09-15T16:42:05Z

Backport of #10075

…ces (opensearch-project#10045) * Fix broken backward comparibility from 2.7 for IndexSorted field indices Signed-off-by: gashutos <gashutos@amazon.com> * Adding CHANGELOG Signed-off-by: gashutos <gashutos@amazon.com> * Update server/src/main/java/org/opensearch/index/IndexSettings.java Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Chaitanya Gohel <104654647+gashutos@users.noreply.github.com> * Removing unwanted logs Signed-off-by: gashutos <gashutos@amazon.com> * Removing unwanted logs Signed-off-by: gashutos <gashutos@amazon.com> * Adding index sort as part of mixed cluster to test this scenario Signed-off-by: gashutos <gashutos@amazon.com> * Removing optimization disable logic Signed-off-by: gashutos <gashutos@amazon.com> * Correcting some comments & version check to before( V_2_7_0) instead onOrBefire(V_2_6_1) since Signed-off-by: gashutos <gashutos@amazon.com> * Resolving spotless check error Signed-off-by: gashutos <gashutos@amazon.com> * Fixing broken UT - last minute checkin without copile Signed-off-by: gashutos <gashutos@amazon.com> * Improving code coverage to make codcov happy Signed-off-by: gashutos <gashutos@amazon.com> * Correcting typos and adding more tests Signed-off-by: gashutos <gashutos@amazon.com> * Removing unwanted imports Signed-off-by: gashutos <gashutos@amazon.com> --------- Signed-off-by: gashutos <gashutos@amazon.com> Signed-off-by: Chaitanya Gohel <104654647+gashutos@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com>

gashutos · 2023-09-15T16:42:36Z

@reta ^^

reta

Holding the merge till we get green light from release team

github-actions · 2023-09-15T17:14:57Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/25707/
CommitID: 1894a24
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: gashutos <gashutos@amazon.com>

github-actions · 2023-09-15T17:16:08Z

Compatibility status:

Checks if related components are compatible with change 1894a24

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

github-actions · 2023-09-15T17:41:17Z

Compatibility status:

Checks if related components are compatible with change 2e46c30

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

reta

2.10 is cleared out

github-actions · 2023-09-15T17:53:57Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/25709/
CommitID: 2e46c30
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-09-15T18:33:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: null ❌
URL: https://build.ci.opensearch.org/job/gradle-check/25712/
CommitID: 2e46c30
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-09-15T19:22:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/25713/
CommitID: 2e46c30
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-09-15T20:08:30Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/25717/
CommitID: 2e46c30
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

reta · 2023-09-15T21:03:06Z

There is an issue with the fix, #10075 (comment) for the reference, @gashutos is looking

github-actions · 2023-09-15T21:04:04Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/25723/
CommitID: 2e46c30
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Gohel <gashutos@88665a2fc937.ant.amazon.com>

reta · 2023-09-16T15:20:53Z

There is an issue with the fix, #10075 (comment) for the reference, @gashutos is looking

Cleared out

github-actions · 2023-09-16T15:22:45Z

Compatibility status:

Checks if related components are compatible with change af099a8

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

github-actions · 2023-09-16T15:26:05Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/25746/
CommitID: af099a8

codecov · 2023-09-16T15:26:37Z

Codecov Report

Merging #10076 (af099a8) into 2.10 (2166b47) will decrease coverage by 0.02%.
The diff coverage is 70.58%.

@@             Coverage Diff              @@
##               2.10   #10076      +/-   ##
============================================
- Coverage     70.72%   70.71%   -0.02%     
+ Complexity    58153    58112      -41     
============================================
  Files          4807     4807              
  Lines        275047   275063      +16     
  Branches      40431    40433       +2     
============================================
- Hits         194534   194515      -19     
- Misses        63873    63902      +29     
- Partials      16640    16646       +6

Files Changed	Coverage Δ
...org/opensearch/index/fielddata/IndexFieldData.java	`70.37% <0.00%> (-1.33%)`	⬇️
...ain/java/org/opensearch/index/IndexSortConfig.java	`73.17% <33.33%> (-1.83%)`	⬇️
...nsearch/index/fielddata/IndexNumericFieldData.java	`85.07% <80.00%> (-1.14%)`	⬇️
...c/main/java/org/opensearch/index/IndexService.java	`75.38% <100.00%> (+0.10%)`	⬆️
.../main/java/org/opensearch/index/IndexSettings.java	`87.19% <100.00%> (+0.06%)`	⬆️

... and 482 files with indirect coverage changes

reta requested changes Sep 15, 2023

View reviewed changes

Modifying release notes

2e46c30

Signed-off-by: gashutos <gashutos@amazon.com>

reta added the skip-changelog label Sep 15, 2023

andrross approved these changes Sep 15, 2023

View reviewed changes

reta approved these changes Sep 15, 2023

View reviewed changes

gashutos mentioned this pull request Sep 16, 2023

Integ test fix -> Fix broken backward compatibility from 2.7 for IndexSorted field indices #10045 #10087

Merged

Finxing broken UT

af099a8

Signed-off-by: Gohel <gashutos@88665a2fc937.ant.amazon.com>

reta merged commit d684a18 into opensearch-project:2.10 Sep 16, 2023

reta mentioned this pull request Sep 16, 2023

Update 2.10 to include the fix for 2.7 combatibility issue opensearch-project/opensearch-build#4031

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.10] Fix broken backward compatibility from 2.7 for IndexSorted field indi… #10076

[Backport 2.10] Fix broken backward compatibility from 2.7 for IndexSorted field indi… #10076

gashutos commented Sep 15, 2023

gashutos commented Sep 15, 2023

reta left a comment

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

reta left a comment

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

reta commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

reta commented Sep 16, 2023

github-actions bot commented Sep 16, 2023

github-actions bot commented Sep 16, 2023

codecov bot commented Sep 16, 2023

[Backport 2.10] Fix broken backward compatibility from 2.7 for IndexSorted field indi… #10076

[Backport 2.10] Fix broken backward compatibility from 2.7 for IndexSorted field indi… #10076

Conversation

gashutos commented Sep 15, 2023

gashutos commented Sep 15, 2023

reta left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 15, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 15, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 15, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

reta left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 15, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 15, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 15, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Sep 15, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Sep 16, 2023

github-actions bot commented Sep 16, 2023

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Sep 16, 2023

Gradle Check (Jenkins) Run Completed with:

codecov bot commented Sep 16, 2023

Codecov Report