Remove conflicting static method from Metadata.Custom interface

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
opensearch-project · Jun 4, 2024 · b7fe838 · b7fe838
1 parent 10f4ce9
commit b7fe838
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/server/src/main/java/org/opensearch/cluster/metadata/Metadata.java b/server/src/main/java/org/opensearch/cluster/metadata/Metadata.java
@@ -181,11 +181,6 @@ static Custom fromXContent(XContentParser parser, String name) throws IOExceptio
             // handling any Exception is caller's responsibility
             return parser.namedObject(Custom.class, name, null);
         }
-
-        // static Custom fromXContent(XContentParser parser) throws IOException {
-        // String currentFieldName = parser.currentName();
-        // return fromXContent(parser, currentFieldName);
-        // }
     }
 
     public static final Setting<Integer> DEFAULT_REPLICA_COUNT_SETTING = Setting.intSetting(

diff --git a/server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java b/server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
@@ -145,11 +145,10 @@ public class RemoteClusterStateService implements Closeable {
         TemplatesMetadata::fromXContent
     );
 
-    // this object is only used for writing object, reader is not essential for this object
     public static final ChecksumBlobStoreFormat<Metadata.Custom> CUSTOM_METADATA_FORMAT = new ChecksumBlobStoreFormat<>(
         "custom",
         METADATA_NAME_FORMAT,
-        null
+        null // no need to reader here, as this object is only used to write/serialize the object
     );
 
     /**