Remove conflicting method from interface

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
opensearch-project · Jun 4, 2024 · 10f4ce9 · 10f4ce9
1 parent 558a4c2
commit 10f4ce9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/server/src/main/java/org/opensearch/cluster/metadata/Metadata.java b/server/src/main/java/org/opensearch/cluster/metadata/Metadata.java
@@ -182,10 +182,10 @@ static Custom fromXContent(XContentParser parser, String name) throws IOExceptio
             return parser.namedObject(Custom.class, name, null);
         }
 
-        static Custom fromXContent(XContentParser parser) throws IOException {
-            String currentFieldName = parser.currentName();
-            return fromXContent(parser, currentFieldName);
-        }
+        // static Custom fromXContent(XContentParser parser) throws IOException {
+        // String currentFieldName = parser.currentName();
+        // return fromXContent(parser, currentFieldName);
+        // }
     }
 
     public static final Setting<Integer> DEFAULT_REPLICA_COUNT_SETTING = Setting.intSetting(

diff --git a/server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java b/server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
@@ -145,10 +145,11 @@ public class RemoteClusterStateService implements Closeable {
         TemplatesMetadata::fromXContent
     );
 
+    // this object is only used for writing object, reader is not essential for this object
     public static final ChecksumBlobStoreFormat<Metadata.Custom> CUSTOM_METADATA_FORMAT = new ChecksumBlobStoreFormat<>(
         "custom",
         METADATA_NAME_FORMAT,
-        Metadata.Custom::fromXContent
+        null
     );
 
     /**