This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
Fix timeline #71
Merged
Fix timeline #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinJurcoGlina
suggested changes
Sep 22, 2021
| @@ -80,22 +80,40 @@ const debounceSourceChange = debounce(changeModifiedLayerSource, 200); | |||
| const TimeSeriesSlider = ({ availableDates, modifiedLayer }) => { | |||
| const marks = []; | |||
| const labels = []; | |||
| const { dataDate } = availableDates[0]; | |||
There was a problem hiding this comment.
I would move this into the for cycle and iterate it, let { dataDate } = availableDates[i]; in case some entry doesn't have dataDate
There was a problem hiding this comment.
Fixed:
@srezacova
Show date if dataDate does not exist on timeline
47f99f8
MartinJurcoGlina
approved these changes
Sep 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix timeline
How has this been tested?
Types of changes