Allow model cards and model tabs outside of homepage #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2175 Bundle Size — 10.79MiB (~-0.01%).3159c18(current) vs 3afef19 main#2172(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2175 |
Baseline #2172 |
|
|---|---|---|
 Initial JS |
1.89MiB(+0.53%) |
1.88MiB |
| Initial CSS |
608.01KiB(+0.02%) |
607.91KiB |
 Cache Invalidation |
24.49% |
18.1% |
| Chunks |
226(+1.35%) |
223 |
| Assets |
249(+1.22%) |
246 |
| Modules |
2907(+0.62%) |
2889 |
 Duplicate Modules |
149(-0.67%) |
150 |
| Duplicate Code |
1.81%(-2.16%) |
1.85% |
 Packages |
97 |
97 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 2 changes 1 regression 1 improvement
| Current #2175 |
Baseline #2172 |
|
|---|---|---|
| JS |
8.97MiB (~-0.01%) |
8.97MiB |
| CSS |
892.57KiB (+0.01%) |
892.47KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.24KiB |
1.24KiB |
| Other |
871B |
871B |
Bundle analysis report Branch wuschi:2583-allow-model-cards-ou... Project dashboard
Generated by RelativeCI Documentation Report issue
- Move model code from homecards-mixin.vue into model.js. - Modify model loading / buildPathInModel to avoid circular references in parent and modelPath - call loadSemanticModel after loadSemantics in app.vue - replace calls to loadModel() with calls to loadSemanticModel in home.vue and home-edit.vue Signed-off-by: Thomas Wunschel <4302898+wuschi@users.noreply.github.com>
- do not pass model as property anymore in home.vue / home-edit.vue - add tab components for locations-tab / equipment-tab / properties-tab to avoid having to pass type parameter directly to model-tab - allow oh-locations-tab / oh-equipment-tab / oh-properties-tab in yaml of page-vuew.vue Signed-off-by: Thomas Wunschel <4302898+wuschi@users.noreply.github.com>
…dard widget list - Add "scoped" to location-card / equipment-card / property-card style definition - Add item parameter to widget definitions of oh-location-card / oh-equipment-card / oh-property-card Signed-off-by: Thomas Wunschel <4302898+wuschi@users.noreply.github.com>
Signed-off-by: Thomas Wunschel <4302898+wuschi@users.noreply.github.com>
05768a6 to
c3f33aa
Compare
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
…definitions Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
approved these changes
Aug 12, 2024
bundles/org.openhab.ui/web/src/components/widgets/standard/oh-equipment-card.vue
Outdated
Show resolved
Hide resolved
…m event Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
added a commit
that referenced
this pull request
Dec 28, 2024
Related to #2584 and openhab/openhab-core#4466. This avoids that the global SSE connection is always established, and therefore reduces problems with the max parallel HTTP connections limitation. The global SSE connection is now only established if the web audio sink or the command Item are enabled. Whilst this change potentially makes the UI not reload the model automatically on change, practically the now removed mechanism might haven't been really useful at all because the model is already reloaded on Main UI start, and if SSE was not connected the moment an Item changed the mechanism did not trigger. Signed-off-by: Florian Hotze <dev@florianhotze.com>
florian-h05
added a commit
that referenced
this pull request
Dec 28, 2024
Related to #2584 and openhab/openhab-core#4466. This avoids that the global SSE connection is always established, and therefore reduces problems with the max parallel HTTP connections limitation. The global SSE connection is now only established if the web audio sink or the command Item are enabled. Whilst this change potentially makes the UI not reload the model automatically on change, practically the now removed mechanism might haven't been really useful at all because the model is already reloaded on Main UI start, and if SSE was not connected the moment an Item changed the mechanism did not trigger. Signed-off-by: Florian Hotze <dev@florianhotze.com> (cherry picked from commit 5d7f35a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2583. Fixes #1591.
This moves model loading code to a new Vuex store module named
model.Model loading is now done by app.vue on init and when an Item change event is received through SSE.
home.vue and home-edit.vue now get the model from the Vuex store instead of loading it.
Add tab components for locations-tab, equipment-tab and properties-tab for easy usage in tabbed pages.
Add card components for oh-.location-card, oh-equipment-card and oh-property-card to standard widget list.