Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sbus] Initial contribution #18019

Merged
merged 1,278 commits into from
Feb 12, 2025
Merged

[sbus] Initial contribution #18019

merged 1,278 commits into from
Feb 12, 2025

Conversation

cipianpascu
Copy link
Contributor

No description provided.

@cipianpascu cipianpascu requested review from GiviMAD and a team as code owners January 2, 2025 07:46
lolodomo and others added 28 commits January 2, 2025 09:49
Related to openhab#17636

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
I made various changes and fixes to the ONVIF connection in the IpCamera binding.

Signed-off-by: David Masshardt <david@masshardt.ch>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* [solarman] Added LSE-3 (LAN Stick Logger) Support (openhab#17559)

Signed-off-by: Peter Kretz <peter.kretz@kretz-net.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Resolves openhab#17316

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* add vin as representation property

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* add adblue channel for combustion vehicles

Signed-off-by: Bernd Weymann <bernd.weymann@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Felix Schneider <mail@fschneider.me>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* Add totalRain channel

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* Add things, items, and sitemap for heat pump and solar module.
* Use UOM for all items.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* Improvements
* Sync config with readme
* Fix unit detection
* Fix NPE

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* Remove apache

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* Upgrade XStream from 1.4.20 to 1.4.21, fixes CVE-2024-47072.
  See changelog at https://x-stream.github.io/changes.html#1.4.21

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
…openhab#17769)

Since no read timeout was set, reads blocked indefinitely, which in case
of unreachable receiver led to blocking the OH thing handler thread
pool, since multiple requests are launched into the thread pool
simultaneously.

Fixes openhab#17768

Signed-off-by: Danny Baumann <dannybaumann@web.de>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* Refactor test to verify UTC timestamp independently of time-zone

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* Some binding enhancements

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
…hab#17755) (openhab#17770)

* [Onkyo] Set "CurrentURIMetaData" for "SetAVTransportURI" action (openhab#17755)

Signed-off-by: Krzysztof Goworek <krzysztof.goworek@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: AndrewFG <software@whitebear.ch>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: AndrewFG <software@whitebear.ch>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
… to fix Alexa … (openhab#17772)

* Change uniqueid to make the earlier octects more unique to fix Alexa discovery.

Signed-off-by: Mike Major <mike_j_major@hotmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: AndrewFG <software@whitebear.ch>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
* [metOfficeDataHub] Initial Commit for v4

[metOfficeDataHub] Initial code commit.

Signed-off-by: David Goodyear <david.goodyear@gmail.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
cipianpascu and others added 11 commits January 21, 2025 21:53
Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <ciprianpascu@yahoo.com>
Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <ciprianpascu@yahoo.com>
Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <ciprianpascu@yahoo.com>
Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <ciprianpascu@yahoo.com>
…ding/sbus/handler/AbstractSbusHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <ciprianpascu@yahoo.com>
…ding/sbus/handler/AbstractSbusHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <ciprianpascu@yahoo.com>
…ding/sbus/handler/SbusBridgeHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: Ciprian Pascu <ciprianpascu@yahoo.com>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
@cipianpascu
Copy link
Contributor Author

hey @lsiepel,
After reverting the feature changes, the build no longer works. Please help me fix it.
Thank you

Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Ciprian Pascu added 4 commits January 24, 2025 10:15
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
@cipianpascu
Copy link
Contributor Author

hey @lsiepel ,

Why does the maven command exclude the karaf module from the reactor?

mvn clean verify -B -T 1.5C -U -am -amd -pl :org.openhab.binding.sbus,:org.openhab.addons.bom.openhab-core-index,:org.openhab.addons.bom.runtime-index,:org.openhab.addons.bom.test-index,-:org.openhab.addons.reactor.features.karaf,-:org.openhab.addons.features.karaf.openhab-addons,-:org.openhab.addons.features.karaf.openhab-addons-external

Everything works fine if I remove the dash in front of the karaf module.

@lsiepel
Copy link
Contributor

lsiepel commented Feb 5, 2025

I have not experienced this before. Maybe @wborn can share his view on this?

@cipianpascu
Copy link
Contributor Author

Hi @GiviMAD , @wborn ,

Please help me fix the feature dependency issue.

Thank you,
Ciprian

@wborn
Copy link
Member

wborn commented Feb 10, 2025

Ciprian Pascu added 2 commits February 10, 2025 21:09
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
@cipianpascu
Copy link
Contributor Author

Thank you @wborn , @lsiepel for your guidance. The sbus integration is ready.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM
Now, you could add the binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website

@lsiepel lsiepel merged commit 2a7a76f into openhab:main Feb 12, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.