[ism8] Extend example sitemap #17738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add things, items, and sitemap for heat pump and solar module. * Use UOM for all items. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
|
The examples have German labels. I know they where already there, but if you are looking at it, would it be possible to adjust hem to English? |
|
@lsiepel Fair point. Though, the documentation of ism8 is available only in German as well, and most of the item names and descriptions seem to be derived from the docs. When I start translating this, it will certainly sound wrong.... Not sure how to proceed on this. |
|
Wolf devices are being sold here in NL. As the rest is already in german it is consistent, so let's take this improvement as is. |
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
* Add things, items, and sitemap for heat pump and solar module. * Use UOM for all items. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
weymann
pushed a commit
to weymann/openhab-addons
that referenced
this pull request
Dec 25, 2024
* Add things, items, and sitemap for heat pump and solar module. * Use UOM for all items. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
* Add things, items, and sitemap for heat pump and solar module. * Use UOM for all items. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds example code needed for heat pumps. Implementation of new channels was done in #17688.
Closes: #17682