Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCI configuration #666

Closed
wants to merge 1 commit into from
Closed

Fix CircleCI configuration #666

wants to merge 1 commit into from

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented May 18, 2018

Relates to #630

As discussed in #645 in this comment, this pull request fixes:

  • The overlapping of caches between different python versions
  • CircleCI workflow's job dependencies

Please note this is a small subset of #662

@bonjourmauko bonjourmauko added flow:team:doing kind:ci Continuous ops, integration & deployment labels May 18, 2018
@bonjourmauko bonjourmauko self-assigned this May 18, 2018
@fpagnoux
Copy link
Member

Nice strategy to avoid duplication! Separating the caches for Python 2 and 3 was tricky, as Circle doesn't let use your own environment variable in the cache key 😞.

As discussed in Slack, and given that we seem to have something that seems to work right now, I'm in favor of delivering first, and refactoring after, as we don't know for sure what issues we'll face when we try to factorize the deployment step

@MattiSG
Copy link
Member

MattiSG commented May 19, 2018

I believe it's worth waiting for the dust to settle on openfisca/country-template#41 and then bring back knowledge to here 😉

@fpagnoux
Copy link
Member

Superseded by #671.

Feel free to open another PR with the improvement you'll find relevant, if you wish 🙂

@fpagnoux fpagnoux closed this May 22, 2018
@bonjourmauko bonjourmauko deleted the python3-circleci branch May 30, 2018 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:ci Continuous ops, integration & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants