Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup py3 #662

Merged
merged 2 commits into from
May 21, 2018
Merged

Fixup py3 #662

merged 2 commits into from
May 21, 2018

Conversation

fpagnoux
Copy link
Member

@fpagnoux fpagnoux commented May 15, 2018 •
edited by bonjourmauko
Loading

Relates to #630

  • Fixup Python 3 compatibility
  • Automatically Publish Python 3 versions in the CI

Publishing works both for Python 3 and Python 2.
The Python 2 deploy script is in charge of publishing the tag and deploying the API, as this should be done only once.

fpagnoux
fpagnoux commented May 15, 2018
View reviewed changes
.circleci/config.yml Outdated
workflows:
version: 2
openfisca-core:
jobs:
- checkout
- dependencies:
context: Py2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These contexts are defined in the CircleCI console.
This is the only way I managed to create an environment variable I could use to distinguish the Python 2 and 3 dependencies cache.

@fpagnoux fpagnoux force-pushed the fixup-py3 branch 6 times, most recently from ecd78fa to 1152678 Compare May 16, 2018 13:40
@fpagnoux
Copy link
Member Author

Actually, I'm still working on the CircleCI config, due to openfisca/country-template#40.

@fpagnoux fpagnoux force-pushed the fixup-py3 branch 9 times, most recently from 560bcae to d685d1f Compare May 16, 2018 16:35
@fpagnoux
Copy link
Member Author

Discussion on the Circle config happening here: openfisca/country-template#41.

@bonjourmauko bonjourmauko mentioned this pull request May 18, 2018
Closed
@bonjourmauko bonjourmauko added note:packaging kind:ci Continuous ops, integration & deployment labels May 18, 2018
@bonjourmauko bonjourmauko mentioned this pull request May 18, 2018
Closed
6 tasks
@fpagnoux
Copy link
Member Author

fpagnoux commented May 18, 2018 •
edited
Loading

Striping this PR for all the Circle Change, so that we can deal with the fixup first.
I will open an new PR when https://github.com/openfisca/country-template is merged.

@fpagnoux
Copy link
Member Author

France tests pass both on Python 2 and Python 3 with this fixup.

This should guarantee that no other fixup will be needed 😅 . I probably should have tested france before merging the PR that pretended to make Core fully compatible with Python 3, my bad.

bonjourmauko
bonjourmauko approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@bonjourmauko bonjourmauko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fpagnoux, works perfectly in both Python 2.x and 3.x.

@fpagnoux fpagnoux merged commit 61abbfe into master May 21, 2018
@fpagnoux fpagnoux deleted the fixup-py3 branch May 21, 2018 16:40
@bonjourmauko bonjourmauko added kind:fix Bugs are defects and failure demand. and removed flow:team:doing kind:ci Continuous ops, integration & deployment labels Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonjourmauko bonjourmauko bonjourmauko approved these changes

@sandcha sandcha Awaiting requested review from sandcha

@Anna-Livia Anna-Livia Awaiting requested review from Anna-Livia

Assignees

@fpagnoux fpagnoux

Labels
kind:fix Bugs are defects and failure demand.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpagnoux @bonjourmauko