small change in aggregating peer eval grades (rounds up) #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbau Awesome, looks good to me. |
| @@ -526,7 +526,7 @@ def _parse_score_msg(self, score_msg, system, join_feedback=True): | |||
| feedback = "".join(feedback_items) | |||
| else: | |||
| feedback = feedback_items | |||
| score = int(median(score_result['score'])) | |||
| score = int(round(median(score_result['score']))) | |||
There was a problem hiding this comment.
Do you want round or math.ceil? It sounded like sef always wanted the highest possible integer value.
|
let me talk to @sefk, but I think either works for [0,1] |
|
actually we decided we do want round, since both work anyway. |
jbau
added a commit
that referenced
this pull request
Aug 19, 2013
small change in aggregating peer eval grades (rounds up)
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
…yllabi Try and find a run-specific syllabus before loading a course-specific syllabus
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Apr 19, 2016
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Apr 19, 2016
…97_Score_Status Fix Score Status & pep8 openedx#697
e-kolpakov
referenced
this pull request
in open-craft/edx-platform
Jun 22, 2016
YONK-302: Adds API endpoint to link Organization permission groups with users
caesar2164
added a commit
to caesar2164/edx-platform
that referenced
this pull request
Oct 16, 2017
…-master-pattern-library Install Stanford UX Pattern Library from master
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@VikParuchuri @natea
The rounding up change we had talked about. With test!