Fix Score Status & pep8 openedx#697

nttks · Apr 1, 2016 · ab3beac · ab3beac
1 parent 996e79a
commit ab3beac
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/biz/djangoapps/ga_achievement/management/commands/tests/test_update_biz_score_status.py b/biz/djangoapps/ga_achievement/management/commands/tests/test_update_biz_score_status.py
@@ -301,7 +301,7 @@ def test_none_user_profile_and_user_standing_contract_disabled_update_biz_score_
 
         for score_order_dict in score_list:
             self.assertEqual(SCORE_STORE_FIELD_STUDENT_STATUS_DISABLED,
-                          score_order_dict[SCORE_STORE_FIELD_STUDENT_STATUS])
+                             score_order_dict[SCORE_STORE_FIELD_STUDENT_STATUS])
             break
 
     @override_settings(BIZ_SET_SCORE_COMMAND_OUTPUT=command_output_file.name)

diff --git a/biz/djangoapps/ga_achievement/score_store.py b/biz/djangoapps/ga_achievement/score_store.py
@@ -102,14 +102,26 @@ def create_list_for_w2ui(cls, items):
                         'field': _(SCORE_STORE_FIELD_STUDENT_STATUS),
                         'caption': _(SCORE_STORE_FIELD_STUDENT_STATUS),
                         'type': 'list',
-                        'options': {'items': [_('Enrolled'), _('Unenrolled'), _('Disabled')]},
+                        'options': {
+                            'items': [
+                                _(SCORE_STORE_FIELD_STUDENT_STATUS_NOT_ENROLLED),
+                                _(SCORE_STORE_FIELD_STUDENT_STATUS_ENROLLED),
+                                _(SCORE_STORE_FIELD_STUDENT_STATUS_UNENROLLED),
+                                _(SCORE_STORE_FIELD_STUDENT_STATUS_DISABLED)
+                            ]
+                        },
                     })
                 elif field == _(SCORE_STORE_FIELD_CERTIFICATE_STATUS):
                     searches.append({
                         'field': _(SCORE_STORE_FIELD_CERTIFICATE_STATUS),
                         'caption': _(SCORE_STORE_FIELD_CERTIFICATE_STATUS),
                         'type': 'list',
-                        'options': {'items': [_('Downloadable'), _('Unpublished')]},
+                        'options': {
+                            'items': [
+                                _(SCORE_STORE_FIELD_CERTIFICATE_STATUS_DOWNLOADABLE),
+                                _(SCORE_STORE_FIELD_CERTIFICATE_STATUS_UNPUBLISHED)
+                            ]
+                        },
                     })
                 else:
                     searches.append({'field': _(field), 'caption': _(field), 'type': 'text'})