Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It seems like self.tabs is getting set to an empty set [] now rather tha... #481

Merged
merged 2 commits into from
Jul 23, 2013
Merged

It seems like self.tabs is getting set to an empty set [] now rather tha... #481

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8584aae
It seems like self.tabs is getting set to an empty set [] now rather …
Jul 23, 2013
0b6932f
add new test to assert that course creation will populate default tab…
Jul 23, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/lib/xmodule/xmodule/course_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ def __init__(self, *args, **kwargs):
continue

# TODO check that this is still needed here and can't be by defaults.
if self.tabs is None:
if not self.tabs or (isinstance(self.tabs, list) and len(self.tabs) == 0):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not self.tabs:
is sufficient. That's what I put into the release.

# When calling the various _tab methods, can omit the 'type':'blah' from the
# first arg, since that's only used for dispatch
tabs = []
Expand Down