It seems like self.tabs is getting set to an empty set [] now rather tha... #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than None. This causes the tab defaulting to not populate, leading to crashes in the LMS if someone makes a new course with additional tabs (e.g. static tabs or pdf-textbooks)
|
@dmitchell can you review? Let's talk to Miki and Jay about cherry picking. I presume we want to wait until tests pass in any case. |
| @@ -410,7 +410,7 @@ def __init__(self, *args, **kwargs): | |||
| continue | |||
|
|
|||
| # TODO check that this is still needed here and can't be by defaults. | |||
| if self.tabs is None: | |||
| if not self.tabs or (isinstance(self.tabs, list) and len(self.tabs) == 0): | |||
There was a problem hiding this comment.
if not self.tabs:
is sufficient. That's what I put into the release.
…s as expected. Also update factory to not override defaults on tabs array. Also simplfy self.tab test condition.
|
@dmitchell added unit test in CMS - there were already some tab tests there, so I just added a new one. Was able to repro bug in unit test and then "fix" it, confirming it via the unit test. |
| @@ -38,16 +38,6 @@ def _create(cls, target_class, **kwargs): | |||
| new_course.display_name = display_name | |||
|
|
|||
| new_course.lms.start = datetime.datetime.now(UTC).replace(microsecond=0) | |||
| new_course.tabs = kwargs.pop( | |||
|
👍 |
chrisndodge
pushed a commit
that referenced
this pull request
Jul 23, 2013
…lization It seems like self.tabs is getting set to an empty set [] now rather tha...
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
* kc/logistration_enable_footer_and_custom_form: Customize logistration registration page Show footer for logistration pages
xavierchan
pushed a commit
to xavierchan/edx-platform-1
that referenced
this pull request
Aug 19, 2019
Style(HMM): Change style for title
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...n None. This causes the tab defaulting to not populate, leading to crashes in the LMS if someone makes a new course with additional tabs (e.g. static tabs or pdf-textbooks)