Crowdsourced Hints - "0.2 release" #442
Conversation
|
Seems like a test is failing. Can you fix it? |
| @@ -876,6 +876,27 @@ def get_score(self, student_answers): | |||
|
|
|||
| # TODO: add check_hint_condition(self, hxml_set, student_answers) | |||
|
|
|||
| def answer_compare(self, a, b): | |||
There was a problem hiding this comment.
Why not compare_answer? That way is more consistent with the naming of other methods.
|
I closed the PR accidentally, reopening. |
| variables = samples.split('@')[0].split(',') | ||
| numsamples = int(samples.split('@')[1].split('#')[1]) | ||
| sranges = zip(*map(lambda x: map(float, x.split(",")), | ||
| samples.split('@')[1].split('#')[0].split(':'))) |
There was a problem hiding this comment.
Probably worth holding on to a version of samples.split('@') since you seem to use it a number of times.
|
@fephsun do you think this branch is ready to be merged? if so, can you fix the tests? |
|
Actually, can we roll the wizard-style UX into this, as well? I'll push that up in a bit. Just have to fix some pep/pylint errors. |
|
Just added the new UX. The pep8 and pylint errors aren't in code that I touched, so I think this is good. |
|
@rocha Merge now? |
|
Let me take a look first. Thanks. On Wed, Aug 7, 2013 at 9:58 AM, Felix Sun notifications@github.com wrote:
|
|
@auraz @vaxXxa |
|
@fephsun, ok. We will review this code at Monday? Is it ok? |
|
@vaxXxa Yeah, Monday is fine. Thanks for getting back to me so quickly. |
| with this problem's tolerance. | ||
| """ | ||
| return compare_with_tolerance( | ||
| evaluator(dict(), dict(), a), |
There was a problem hiding this comment.
Please use {} everywhere instead of dict():
In [6]: %timeit dict()
1000000 loops, best of 3: 277 ns per loop
In [7]: %timeit {}
10000000 loops, best of 3: 44.2 ns per loop
Fixed broken tests.
Hint submission is hidden behind a link, if there are hints to vote on.
Still requires a little polishing, I think.
the bottom of the hint div, no matter what.
Fixed a css bug in the hinter.
Fixed coffeescript event logging error. Fixed crowdsourced hinter dependence on self.field.append() not working.
…ent-inteception is covered.
|
@valera-rozuvan Still waiting for the js/coffeescript review. I will be around until this Wednesday. Afterwards, I think @rocha can answer questions. |
|
@fephsun I have looked over the CoffeeScript files. They look good. Can you please look into what is causing the build to be unstable? Otherwise, good to merge 👍 |
|
@valera-rozuvan It's pep8/pylint violations from other peoples' commits. I'll deal with this problem today, and merge. |
Crowdsourced Hints - "0.2 release"
|
Congrats! Good luck on the post-deploy support! |
…style Added fix for answer status and show answer to stay in the same place
Fix typo in requirements file, making "pip install" work again
modify price text for program
REV-2126 Value Prop
Applies a bunch of improvements to the crowdsourced hints xmodule.
@rocha