fix: fix redirect unauthenticated users to login middleware for TPA [BB-5090] #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
561c6bc to
1cdd71f
Compare
|
Closing this PR due to issues found. Decision was made to abandon implementation using middleware in favor of implementing it through theming, because it's difficult to find all url that should be whitelisted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues which
RedirectUnauthenticatedToLoginMiddlewarecauses when enabled together with hinted sign in and third part authentication.Useful links
BB-5090
comment that describes the issue
Hinted Sign In