factor out google analytics ids (LMS-2555) #3505
Merged
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adampalay you might want to ping @rlucioni on this PR as he's seeing duplicate GA events since they moved to Segment.io |
|
thanks for the heads up-- @rlucioni ? |
|
@chrisndodge , that wouldn't be a blocker, right? this PR doesn't change the analytics id; it just hides it |
|
I was suggesting you speak with him as @rlucioni interested in us turning off GA in production due to some double counting. This just came up yesterday so it seemed like you two should connect. |
|
ok, got it, i'll send him an email |
|
@chrisndodge and @adampalay, thanks for pinging me. I'm in conversation with @adampalay about disabling any GA tracking code separate from Segment.io |
|
merging this in for now, will add a story to put GA behind a feature flag to do later |
adampalay
added a commit
that referenced
this pull request
Apr 29, 2014
factor out google analytics ids (LMS-2555)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3490 rebased onto the release candidate
@e0d , FYI