Merge pull request #3505 from edx/adam/google-analytics

factor out google analytics ids (LMS-2555)
openedx · Apr 29, 2014 · a2817d9 · a2817d9
2 parents edabab3 + 8ad4cdb
commit a2817d9
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 3 deletions.
diff --git a/lms/djangoapps/linkedin/management/commands/linkedin_mailusers.py b/lms/djangoapps/linkedin/management/commands/linkedin_mailusers.py
@@ -205,7 +205,11 @@ def send_grandfather_email(self, user, certificates, mock_run=False):
                 'linkedin_add_url': self.certificate_url(cert),
             })
 
-        context = {'courses_list': courses_list, 'num_courses': len(courses_list)}
+        context = {
+            'courses_list': courses_list,
+            'num_courses': len(courses_list),
+            'google_analytics': settings.GOOGLE_ANALYTICS_LINKEDIN,
+        }
         body = render_to_string('linkedin/linkedin_email.html', context)
         subject = u'{}, Add your Achievements to your LinkedIn Profile'.format(user.profile.name)
         if mock_run:

diff --git a/lms/envs/aws.py b/lms/envs/aws.py
@@ -397,3 +397,7 @@
 
 ##### ADVANCED_SECURITY_CONFIG #####
 ADVANCED_SECURITY_CONFIG = ENV_TOKENS.get('ADVANCED_SECURITY_CONFIG', {})
+
+##### GOOGLE ANALYTICS IDS #####
+GOOGLE_ANALYTICS_ACCOUNT = AUTH_TOKENS.get('GOOGLE_ANALYTICS_ACCOUNT')
+GOOGLE_ANALYTICS_LINKEDIN = AUTH_TOKENS.get('GOOGLE_ANALYTICS_LINKEDIN')
diff --git a/lms/envs/common.py b/lms/envs/common.py
@@ -421,6 +421,10 @@
 TRACKING_IGNORE_URL_PATTERNS = [r'^/event', r'^/login', r'^/heartbeat']
 TRACKING_ENABLED = True
 
+######################## GOOGLE ANALYTICS ###########################
+GOOGLE_ANALYTICS_ACCOUNT = 'GOOGLE_ANALYTICS_ACCOUNT_DUMMY'
+GOOGLE_ANALYTICS_LINKEDIN = 'GOOGLE_ANALYTICS_LINKEDIN_DUMMY'
+
 ######################## subdomain specific settings ###########################
 COURSE_LISTINGS = {}
 SUBDOMAIN_BRANDING = {}

diff --git a/lms/templates/google_analytics.html b/lms/templates/google_analytics.html
@@ -1,6 +1,6 @@
 <script type="text/javascript">
 var _gaq = _gaq || [];
-_gaq.push(['_setAccount', 'UA-35248639-1']);
+_gaq.push(['_setAccount', ${settings.GOOGLE_ANALYTICS_ACCOUNT}]);
 _gaq.push(['_trackPageview']);
 
 (function() {

diff --git a/lms/templates/linkedin/linkedin_email.html b/lms/templates/linkedin/linkedin_email.html
@@ -393,7 +393,7 @@
             <script type="text/javascript">
             try {
                 var _gaq = _gaq || [];
-                _gaq.push(["_setAccount", "UA-329148-88"]);
+                _gaq.push(["_setAccount", ${google_analytics}]);
                 _gaq.push(["_setDomainName", ".campaign-archive.com"]);
                 _gaq.push(["_trackPageview"]);
                 _gaq.push(["_setAllowLinker", true]);