This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add CSV formatter in new engine #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # legacy/src/main/java/com/amazon/opendistroforelasticsearch/sql/legacy/plugin/RestSQLQueryAction.java
Codecov Report
@@ Coverage Diff @@
## develop #870 +/- ##
===========================================
Coverage 99.85% 99.86%
- Complexity 2148 2217 +69
===========================================
Files 216 225 +9
Lines 4850 5129 +279
Branches 320 336 +16
===========================================
+ Hits 4843 5122 +279
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
|
Could you add the following related issue to the description? I think we should be able to close them after this PR merged. |
Added but the last issue #546 because this PR didn't enable custom separators yet |
dai-chen
reviewed
Dec 9, 2020
...rc/main/java/com/amazon/opendistroforelasticsearch/sql/legacy/plugin/RestSQLQueryAction.java
Outdated
Show resolved
Hide resolved
legacy/src/main/java/com/amazon/opendistroforelasticsearch/sql/legacy/plugin/RestSqlAction.java
Outdated
Show resolved
Hide resolved
...com/amazon/opendistroforelasticsearch/sql/protocol/response/format/CsvResponseFormatter.java
Outdated
Show resolved
Hide resolved
Got it, you can close that one once this merged. Thanks! |
dai-chen
approved these changes
Dec 11, 2020
...rc/main/java/com/amazon/opendistroforelasticsearch/sql/legacy/plugin/RestSQLQueryAction.java
Outdated
Show resolved
Hide resolved
penghuo
reviewed
Dec 11, 2020
penghuo
reviewed
Dec 11, 2020
...com/amazon/opendistroforelasticsearch/sql/protocol/response/format/CsvResponseFormatter.java
Show resolved
Hide resolved
penghuo
reviewed
Dec 11, 2020
...com/amazon/opendistroforelasticsearch/sql/protocol/response/format/CsvResponseFormatter.java
Outdated
Show resolved
Hide resolved
penghuo
approved these changes
Dec 11, 2020
harold-wang
pushed a commit
to harold-wang/sql
that referenced
this pull request
Dec 11, 2020
* support csv format in new engine * skipped some IT cases that are not applicable in new engine * udpate * added escape option * added test for Format * update * update * added IT for ppl * added IT for ppl * added IT for ppl * added license header * added test for sql * added example in protocol doc * addressed comments * added responseParams override method to sql and ppl stats actions * added unit test cases * update * addressed comment * addressed comments
penghuo
pushed a commit
that referenced
this pull request
Dec 15, 2020
* support csv format in new engine * skipped some IT cases that are not applicable in new engine * udpate * added escape option * added test for Format * update * update * added IT for ppl * added IT for ppl * added IT for ppl * added license header * added test for sql * added example in protocol doc * addressed comments * added responseParams override method to sql and ppl stats actions * added unit test cases * update * addressed comment * addressed comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#148 #117 #100
Description of changes:
Added csv formatter
CsvResponseFormatterin new engine. The formatter formats theQueryResultto csv format and by default it sanitizes the result by (1) inserting single-quote in front of header/data if it starts with special characters including+,-,=and@; (2) quoting the header/data if one or more commas (,) in the header/data. The sanitizing can be skipped by adding ansanitizeparam and set it tofalsevalue in the request.User manual updates: https://github.com/chloe-zh/sql/blob/csv-formatter/docs/user/interfaces/protocol.rst
Added tests for the formatter; ignored a couple of legacy tests that are not applicable for the new engine
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.