Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

CSV and JDBC export are 2 different execution paths #148

Closed
galkk opened this issue Aug 9, 2019 · 2 comments
Closed

CSV and JDBC export are 2 different execution paths #148

galkk opened this issue Aug 9, 2019 · 2 comments
Labels
maintenance Improves code quality, but not the product SQL

Comments

@galkk
Copy link
Contributor

galkk commented Aug 9, 2019

CSV and JDBC result formatting have 2 parallel codebases, so fix in one wouldn't work with another and one needs to always remember to double check. Example: CSV formatter supported all aggregations (Percentile, Numeric SimpleValue, Numeric Multiple), and JDBC supported only one: Numeric SimpleValue

Recommendation: the CSV formatter should use results of JDBC formatter and do simple transformation of results. The logic, that is currently not presented in JDBC formatter must be brought there

CSV formatting: CSVResultsExtractor.java
JDBC/RAW: SelectResultSet.java

@galkk galkk added the maintenance Improves code quality, but not the product label Aug 9, 2019
@abbashus
Copy link
Contributor

abbashus commented Aug 9, 2019

+1.

@dai-chen
Copy link
Member

This has been resolved in new query engine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Improves code quality, but not the product SQL
Projects
None yet
Development

No branches or pull requests

3 participants