This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Add Search box to Report Source Selection #286
Merged
davidcui1225
merged 9 commits into
opendistro-for-elasticsearch:dev
from
davidcui1225:searchbox-report-source
Jan 6, 2021
Merged
Add Search box to Report Source Selection #286
davidcui1225
merged 9 commits into
opendistro-for-elasticsearch:dev
from
davidcui1225:searchbox-report-source
Jan 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #286 +/- ##
==========================================
+ Coverage 74.94% 77.27% +2.33%
==========================================
Files 32 32
Lines 1764 1769 +5
Branches 342 348 +6
==========================================
+ Hits 1322 1367 +45
+ Misses 437 397 -40
Partials 5 5
Continue to review full report at Codecov.
|
codecov failed- will add more tests |
akbhatta
approved these changes
Jan 6, 2021
zhongnansu
reviewed
Jan 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything else you can do to resolve the codecov failure?
...lic/components/report_definitions/report_settings/__tests__/report_settings_helpers.test.tsx
Outdated
Show resolved
Hide resolved
Codecov fixed- coverage raised significantly |
zhongnansu
approved these changes
Jan 6, 2021
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Jan 6, 2021
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Jan 7, 2021
zhongnansu
pushed a commit
that referenced
this pull request
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#264
Description of changes:
Report source
selection inReport settings
to beEuiComboBox
vs. Drop-down list. Now users can search for their report sources.Create report definition
no longer has pre-populated report source, users will have to enter it manuallyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.