Add Search box to Report Source Selection (#286)

opendistro-for-elasticsearch · Jan 6, 2021 · 1bf159c · 1bf159c
1 parent 66164c3
commit 1bf159c
Show file tree

Hide file tree

Showing 10 changed files with 2,034 additions and 339 deletions.
diff --git a/kibana-reports/.cypress/integration/01-create.spec.ts b/kibana-reports/.cypress/integration/01-create.spec.ts
@@ -47,6 +47,9 @@ describe('Cypress', () => {
     // enter a report description
     cy.get('#reportSettingsDescription').type('Description for cypress test');
 
+    // select a report source
+    cy.get('.euiComboBox').click({ force: true });
+
     // create an on-demand report definition
     cy.get('#createNewReportDefinition').click({ force: true });
   });

diff --git a/kibana-reports/.cypress/integration/04-download.spec.ts b/kibana-reports/.cypress/integration/04-download.spec.ts
@@ -101,7 +101,7 @@ describe('Cypress', () => {
     // create an on-demand report definition
     cy.get('#createNewReportDefinition').click({ force: true });
 
-    cy.wait(5000);
+    cy.wait(10000);
 
     // visit the details page of the newly created on-demand definition
     cy.get('#reportDefinitionDetailsLink').first().click();

diff --git a/kibana-reports/public/components/report_definitions/create/create_report_definition.tsx b/kibana-reports/public/components/report_definitions/create/create_report_definition.tsx
@@ -131,6 +131,14 @@ export function CreateReport(props) {
     settingsReportNameErrorMessage,
     setSettingsReportNameErrorMessage,
   ] = useState('');
+  const [
+    showSettingsReportSourceError,
+    setShowSettingsReportSourceError
+  ] = useState(false);
+  const [
+    settingsReportSourceErrorMessage,
+    setSettingsReportSourceErrorMessage
+  ] = useState('');
   const [
     showTriggerIntervalNaNError,
     setShowTriggerIntervalNaNError,
@@ -213,7 +221,6 @@ export function CreateReport(props) {
     timeRange: timeRangeParams
   ) => {
     const { httpClient } = props;
-
     //TODO: need better handle
     if (
       metadata.trigger.trigger_type === 'On demand' &&
@@ -228,6 +235,8 @@ export function CreateReport(props) {
       error,
       setShowSettingsReportNameError,
       setSettingsReportNameErrorMessage,
+      setShowSettingsReportSourceError,
+      setSettingsReportSourceErrorMessage,
       setShowTriggerIntervalNaNError,
       timeRange,
       setShowTimeRangeError,
@@ -307,6 +316,8 @@ export function CreateReport(props) {
           timeRange={timeRange}
           showSettingsReportNameError={showSettingsReportNameError}
           settingsReportNameErrorMessage={settingsReportNameErrorMessage}
+          showSettingsReportSourceError={showSettingsReportSourceError}
+          settingsReportSourceErrorMessage={settingsReportSourceErrorMessage}
           showTimeRangeError={showTimeRangeError}
         />
         <EuiSpacer />

diff --git a/kibana-reports/public/components/report_definitions/edit/edit_report_definition.tsx b/kibana-reports/public/components/report_definitions/edit/edit_report_definition.tsx
@@ -49,6 +49,14 @@ export function EditReportDefinition(props) {
     settingsReportNameErrorMessage,
     setSettingsReportNameErrorMessage,
   ] = useState('');
+  const [
+    showSettingsReportSourceError,
+    setShowSettingsReportSourceError
+  ] = useState(false);
+  const [
+    settingsReportSourceErrorMessage,
+    setSettingsReportSourceErrorMessage
+  ] = useState('');
   const [
     showTriggerIntervalNaNError,
     setShowTriggerIntervalNaNError,
@@ -216,6 +224,8 @@ export function EditReportDefinition(props) {
       error,
       setShowSettingsReportNameError,
       setSettingsReportNameErrorMessage,
+      setShowSettingsReportSourceError,
+      setSettingsReportSourceErrorMessage,
       setShowTriggerIntervalNaNError,
       timeRange,
       setShowTimeRangeError,
@@ -294,6 +304,8 @@ export function EditReportDefinition(props) {
           timeRange={timeRange}
           showSettingsReportNameError={showSettingsReportNameError}
           settingsReportNameErrorMessage={settingsReportNameErrorMessage}
+          showSettingsReportSourceError={showSettingsReportSourceError}
+          settingsReportSourceErrorMessage={settingsReportSourceErrorMessage}
           showTimeRangeError={showTimeRangeError}
         />
         <EuiSpacer />