Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Backport nmslib 2.0.11 upgrade to 1.12 #305

Conversation

jmazanec15
Copy link
Member

Issue #, if available:
#302

Description of changes:
Backport update to nmslib upgrade to 2.0.11 to support ARM in older versions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmazanec15 jmazanec15 changed the title Nmslib 2.0.11 back 1.12 Backport upgrade nmslib 2.0.11 to 1.12 Jan 14, 2021
@jmazanec15 jmazanec15 changed the title Backport upgrade nmslib 2.0.11 to 1.12 Backport nmslib 2.0.11 upgrade to 1.12 Jan 14, 2021
@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #305 (d6d1716) into opendistro-1.12 (fbf9566) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             opendistro-1.12     #305   +/-   ##
==================================================
  Coverage              79.49%   79.49%           
  Complexity               359      359           
==================================================
  Files                     58       58           
  Lines                   1414     1414           
  Branches                 129      129           
==================================================
  Hits                    1124     1124           
  Misses                   242      242           
  Partials                  48       48           
Impacted Files Coverage Δ Complexity Δ
...istroforelasticsearch/knn/index/KNNIndexCache.java 92.30% <ø> (ø) 35.00 <0.00> (ø)
...istroforelasticsearch/knn/index/KNNIndexShard.java 92.00% <ø> (ø) 10.00 <0.00> (ø)
...pendistroforelasticsearch/knn/index/KNNWeight.java 97.14% <ø> (ø) 10.00 <0.00> (ø)
...index/codec/KNN80Codec/KNN80DocValuesConsumer.java 70.88% <ø> (ø) 15.00 <0.00> (ø)
...forelasticsearch/knn/index/util/NmsLibVersion.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...stroforelasticsearch/knn/index/v2011/KNNIndex.java 76.74% <100.00%> (ø) 8.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf9566...d6d1716. Read the comment docs.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vamshin vamshin merged commit 804a76b into opendistro-for-elasticsearch:opendistro-1.12 Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants