Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Upgrade nmslib to 2.0.11 #302

Merged

Conversation

jmazanec15
Copy link
Member

Issue #, if available:
#290

Description of changes:
PR upgrades nmslib from 2.0.8 to 2.0.11. 2.0.8 was deleted because of build failure for python bindings. Core code was not changed between update from 2.0.8 to 2.0.11.

gradle build was passing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmazanec15 jmazanec15 added the Enhancements Improvement on existing component label Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #302 (4b5a316) into master (79f7748) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #302   +/-   ##
=========================================
  Coverage     80.51%   80.51%           
- Complexity      388      389    +1     
=========================================
  Files            62       62           
  Lines          1468     1468           
  Branches        130      130           
=========================================
  Hits           1182     1182           
  Misses          239      239           
  Partials         47       47           
Impacted Files Coverage Δ Complexity Δ
...istroforelasticsearch/knn/index/KNNIndexCache.java 92.30% <ø> (ø) 35.00 <0.00> (ø)
...istroforelasticsearch/knn/index/KNNIndexShard.java 92.00% <ø> (ø) 10.00 <0.00> (ø)
...pendistroforelasticsearch/knn/index/KNNWeight.java 97.14% <ø> (ø) 10.00 <0.00> (ø)
...index/codec/KNN80Codec/KNN80DocValuesConsumer.java 70.88% <ø> (ø) 15.00 <0.00> (ø)
...forelasticsearch/knn/index/util/NmsLibVersion.java 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
...stroforelasticsearch/knn/index/v2011/KNNIndex.java 76.74% <100.00%> (ø) 8.00 <1.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79f7748...4b5a316. Read the comment docs.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmazanec15 jmazanec15 merged commit 3595be5 into opendistro-for-elasticsearch:master Jan 14, 2021
jmazanec15 added a commit to jmazanec15/k-NN that referenced this pull request Jan 14, 2021
jmazanec15 added a commit to jmazanec15/k-NN that referenced this pull request Jan 14, 2021
vamshin pushed a commit that referenced this pull request Jan 15, 2021
* Upgrade nmslib to v2.0.8 in JNI library (#291)

* Upgrade nmslib to 2.0.11 (#302)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancements Improvement on existing component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants