Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvest dct:conformsTo for Dataset and Resource #2949

Merged
merged 24 commits into from
Feb 21, 2024
Merged

Harvest dct:conformsTo for Dataset and Resource #2949

merged 24 commits into from
Feb 21, 2024

Conversation

ThibaudDauce
Copy link
Contributor

@ThibaudDauce ThibaudDauce commented Jan 25, 2024 •
edited by maudetes
Loading

@ThibaudDauce ThibaudDauce marked this pull request as ready for review January 25, 2024 16:18
maudetes
maudetes reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've made a first batch of review, but this seems promising!
Don't forget the changelog entry ;)

@ThibaudDauce ThibaudDauce force-pushed the harvest_schemas branch 3 times, most recently from e09c712 to 1cd555d Compare January 30, 2024 14:04
maudetes
maudetes reviewed Jan 31, 2024
View reviewed changes
@maudetes maudetes self-requested a review February 14, 2024 13:56
@ThibaudDauce ThibaudDauce mentioned this pull request Feb 20, 2024
Merged
maudetes
maudetes approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, it was a bit of spaghetti 🍝 to get it right!
We may improve on schema/conformsTo logic with usage later on :)

udata/tests/api/test_datasets_api.py

# Putting `None` as the schema argument do not remove the schema
# Not sure if it's the correct behaviour but it's the normal behaviour on the API v1… :-(
# I think it should be if the key 'schema' is missing, the old value is kept, if the key is present
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the behavior is not totally intuitive, but let's keep it as is in this PR for now.

@ThibaudDauce ThibaudDauce merged commit 88ddde5 into master Feb 21, 2024
1 check passed
@ThibaudDauce ThibaudDauce mentioned this pull request Feb 21, 2024
Closed
@ThibaudDauce ThibaudDauce deleted the harvest_schemas branch March 18, 2024 08:48
This was referenced Mar 19, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maudetes maudetes maudetes approved these changes

@quaxsze quaxsze Awaiting requested review from quaxsze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moissonnage de la métadonnée schéma (dcterms:conformsTo)
2 participants
@ThibaudDauce @maudetes