Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema manipulation #361

Merged
merged 10 commits into from
Feb 22, 2024
Merged

Fix schema manipulation #361

merged 10 commits into from
Feb 22, 2024

Conversation

ThibaudDauce
Copy link
Contributor

@ThibaudDauce ThibaudDauce commented Feb 20, 2024

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThibaudDauce
Copy link
Contributor Author

I think there is still an issue for the Resource in Vue:

https://github.com/etalab/udata-front/blob/5b63e7bf20944fedc3f42fa52b94a405f5f45f59/udata_front/theme/gouvfr/datagouv-components/src/components/ResourceAccordion/ResourceAccordion.vue#L390

I think in Vue there is no problem to access a dict or a class like this (since dict and classes are the same thing in JSON)

@ThibaudDauce ThibaudDauce requested review from nicolaskempf57 and removed request for maudetes February 21, 2024 13:18
@ThibaudDauce ThibaudDauce force-pushed the harvest_schema branch 2 times, most recently from d9874ce to 094fd49 Compare February 22, 2024 13:51
@ThibaudDauce ThibaudDauce merged commit 7bf8d16 into master Feb 22, 2024
7 checks passed
@ThibaudDauce ThibaudDauce deleted the harvest_schema branch February 22, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants