chore(api): move infrastructure/v1 to apis folder #894
Conversation
|
is this all about to get the API exposed so can easily document them? |
Not really, but if so a nice side effect. :) Basically just that they are all APIs and should never have been placed anywhere else. #SpringCleaning |
ah, sure. |
|
It's exposed via the other APIs either way so having it in another folder won't hide it :) |
Collect all APIs under the same parent package structure Signed-off-by: Aslak Knutsen <aslak@4fs.no>
There was a problem hiding this comment.
Thanks for fixing my mess :) I immediately had mixed feelings with this package after merging PR but somehow never thought about paying this debt back. I think it should be kept together with other structs which are exposed through CRD and processed by kubebuilder.
LGTM
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bartoszmajsak, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4090bec to
b0fad5c
Compare
|
New changes are detected. LGTM label has been removed. |
|
FYI @israel-hdez ^ dont get surprised after rebase code |
…ces#894) Collects all APIs under the same parent package structure.
* chore(api): move infrastructure/v1 to apis folder (#894) Collects all APIs under the same parent package structure. * fix: Rework operator precondition checks (#899) * init commit * tmp: switch to subsciption * tmp * fix up testing * linter on import * minor self nits * add bracket, make * use found,err for checking subscription Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * fix import + test error expected outputs * directly return errs rather than log and ret Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * remove unused log var from condiitons * move const fixtures to separate package * move creating op subscription to function * rename noop features in testing * remove redundant comments Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * move CreateSubscription to fixtures --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore(feature): passes component name instead of whole struct (#903) Co-authored-by: Aslak Knutsen <aslak@4fs.no> Simplify API as there is no need to pass the entire Component struct. * kserve: add grpconly envoy filter (#888) --------- Co-authored-by: Aslak Knutsen <aslak@4fs.no> Co-authored-by: Cameron Garrison <cgarriso@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Daniele <d.trifiro@me.com>
Description
Collect all APIs under the same parent package structure
How Has This Been Tested?
Manually
Merge criteria: