Update readme.md #890

AjayJagan · 2024-03-05T10:40:35Z

Updates the Readme.md file.

Description

Pre-requisite operators and their installation for every component
API documentation of every field in DSCI and DSC

Merge criteria:

The commits are squashed in a cohesive manner and have meaningful messages.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

aslakknutsen · 2024-03-05T10:47:23Z

README.md

  You can also use operator to create default DSCI CR by removing env variable DISABLE_DSC_CONFIG from CSV following restart operator pod.

 3. Create [DataScienceCluster](#example-datasciencecluster) CR to enable components

+### API overview


How was this overview created? Is there a command or something that could be included in the Makefile or similar. Else I suspect this will be out of date before this commit hit the main branch..

I had to do it manually 😓

I guess whenever a new section in the API is created, it can be updated right. We can add it as a guideline in the contribution docs

@AjayJagan Can you see a way to make it into a command? What's the source for the info?

The source is the the CRDs generated in the manifests folder

@bartoszmajsak I'd hold of a little on it just because.. maybe, just maybe we'll include it in api with some upcoming feature rework.. hehe

@AjayJagan hmm.. yeah, it's not really it's own group but part of DSCI.. What happens if you copy the groupversion_info.go from the dsci folder over to infrastructure as well?

@bartoszmajsak Was it perhaps intended that it could be included on both dsci and dsc level? It seems to only be dsci atm.

@aslakknutsen Yep that works :D

Was it perhaps intended that it could be included on both dsci and dsc level? It seems to only be dsci atm.

@aslakknutsen it's used in both actually, transitively, e.g.

opendatahub-operator/components/kserve/kserve.go

Line 51 in 927340a

Serving infrav1.ServingSpec `json:"serving,omitempty"`

in that case, how do we link it to 2 group versions 🤔

zdtsw · 2024-03-06T15:18:16Z

@AjayJagan just to be sure: we will cover readme https://github.com/opendatahub-io/opendatahub-operator/blob/e7b7c999bfaa24b147d14838dc83873dac17112f/components/README.md too ,or the scope is only for the top readme?

AjayJagan · 2024-03-06T16:05:19Z

@AjayJagan just to be sure: we will cover readme https://github.com/opendatahub-io/opendatahub-operator/blob/e7b7c999bfaa24b147d14838dc83873dac17112f/components/README.md too ,or the scope is only for the top readme?

Sure @zdtsw , I will cover them as well

bartoszmajsak · 2024-03-07T08:37:57Z

With #894 now merged I was thinking we that should automate the kubebuilder assets generation and documentation process as a GH Action for example.

From time to time we face the problem that PR gets merged with changes to godoc (or even struct) of CRD, but manifests do not reflect it as we forgot to run appropriate make targets before opening the PR, resulting in a follow-up PR with those changes. Instead of reminding the author to do this manually we can help them with little automation here.

I think we can make a github action reacting on changes of apis/ folder only:

on:
  pull_request:
    paths:
      - 'apis/**'

which will do the following

runs make generate manifests
if any changes - commit changes with a message e.g. gh-action: updates kubebuilder assets
runs make api-docs
if any changes - commit changes with a message e.g. gh-action: updates api docs
pushes back to PR branch or fail with PR comment if contributors are not allowed to do so

WDYT?

Makefile

README.md

crd-ref-docs.config.yaml

AjayJagan · 2024-03-07T08:41:35Z

With #894 now merged I was thinking we that should automate the kubebuilder assets generation and documentation process as a GH Action for example.

From time to time we face the problem that PR gets merged with changes to godoc (or even struct) of CRD, but manifests do not reflect it as we forgot to run appropriate make targets before opening the PR, resulting in a follow-up PR with those changes. Instead of reminding the author to do this manually we can help them with little automation here.

I think we can make a github action reacting on changes of apis/ folder only:
on:
  pull_request:
    paths:
      - 'apis/**'
which will do the following

runs make generate manifests

if any changes - commit changes with a message e.g. gh-action: updates kubebuilder assets

runs make api-docs

if any changes - commit changes with a message e.g. gh-action: updates api docs

pushes back to PR branch or fail with PR comment if contributors are not allowed to do so

WDYT?

cool idea! can I include this as a part of this PR itself?

bartoszmajsak · 2024-03-07T08:50:21Z

can I include this as a part of this PR itself?

@AjayJagan let's avoid scope creep and try to keep PRs focused. I think this would be a good follow-up improvement and if the team agrees this is beneficial for the project by all means go for it. I can help you with some pointers as we did release automation using gh-actions with similar steps (committing stuff back to the PR branch). Here's how it worked in action maistra/istio-workspace#1126 (see comments and commits in the history line)

AjayJagan · 2024-03-07T08:52:25Z

can I include this as a part of this PR itself?

@AjayJagan let's avoid scope creep and try to keep PRs focused. I think this would be a good follow-up improvement and if the team agrees this is beneficial for the project by all means go for it. I can help you with some pointers as we did release automation using gh-actions with similar steps (committing stuff back to the PR branch). Here's how it worked in action maistra/istio-workspace#1126 (see comments and commits in the history line)

Yep makes sense. I can take up the follow up PR. WDYT @VaishnaviHire @zdtsw

VaishnaviHire · 2024-03-07T14:36:04Z

README.md


-3. Create [DataScienceCluster](#example-datasciencecluster) CR to enable components
+  3. Create [DataScienceCluster](#example-datasciencecluster) CR to enable components

 ## Dev Preview



We can get rid of Dev Preview section and dev-preview.md. It was created when we did not have odh releases for v2

VaishnaviHire · 2024-03-07T14:37:08Z

README.md

@@ -63,12 +83,12 @@ Refer [Dev-Preview.md](./docs/Dev-Preview.md) for testing preview features.



Given above change, Developer Guide can be moved to --> ## Developer Guide

VaishnaviHire · 2024-03-08T19:49:35Z

/lgtm

openshift-ci · 2024-03-09T16:07:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@build

* Update readme.md * update links to the respective schemas * use crd-ref-doc for api doc generation * update readme docs * update pr based on comments * change k8s version * remove dev preview * update doc to get kserve value * add @build back in makefile * add make api-docs under ##@ Development

@build

* Update readme.md * update links to the respective schemas * use crd-ref-doc for api doc generation * update readme docs * update pr based on comments * change k8s version * remove dev preview * update doc to get kserve value * add @build back in makefile * add make api-docs under ##@ Development (cherry picked from commit cb7a6fe)

…o#776) Squashed commit due to buildability since ComponentInterface has changed. feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

…o#776) Squashed commit due to buildability since ComponentInterface has changed. feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid double squashing due to merge policy. modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid double squashing due to merge policy. modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (opendatahub-io#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (opendatahub-io#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (opendatahub-io#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (opendatahub-io#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (opendatahub-io#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (opendatahub-io#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013)

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid double squashing due to merge policy. modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (opendatahub-io#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (opendatahub-io#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (opendatahub-io#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (opendatahub-io#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (opendatahub-io#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (opendatahub-io#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013) feat: add managed model registry prometheus job, metrics, and alering rules, fixes RHOAIENG-4273 (cherry picked from commit f811d67)

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid double squashing due to merge policy. modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (opendatahub-io#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (opendatahub-io#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (opendatahub-io#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (opendatahub-io#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (opendatahub-io#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (opendatahub-io#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013) feat: add managed model registry prometheus job, metrics, and alering rules, fixes RHOAIENG-4273 (cherry picked from commit f811d67) modelregistry: partial: fix: add check for all platform offering on components Partial application of ab7e04e ("fix: add check for all platform offering on components (opendatahub-io#1205)") ModelRegistry related. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid double squashing due to merge policy. modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (opendatahub-io#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (opendatahub-io#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (opendatahub-io#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (opendatahub-io#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (opendatahub-io#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (opendatahub-io#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013) feat: add managed model registry prometheus job, metrics, and alering rules, fixes RHOAIENG-4273 (cherry picked from commit f811d67) modelregistry: partial: fix: add check for all platform offering on components Partial application of ab7e04e ("fix: add check for all platform offering on components (opendatahub-io#1205)") ModelRegistry related. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 (opendatahub-io#1221) * feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added registriesNamespace property in references to model registry component in docs, samples, etc. Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: updated api-overview.md Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: add missing field in setupDSCInstance() Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added debug log for failing e2e test * debug: added log messages in test dsc creation Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * debug: make registriesNamespace omitempty so apiserver will set the default value, clean testDSCCreation with more log messages Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * update: modelregistry with namespace - add namespace for rhoai case - remove omitemptry on namespace: if user does not set it, it will get default value to use. since its type is string Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: test need to update for modelreg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: cleanup debug info in test cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: make registriesNamespace immutability check dynamic in cel validation rule * fix: refactor validation rule, set registriesNamespace to optional, add patch func in modelregistry to set default value * fix: add defaulting webhook including envtest, remove patch from modelregistry component * fix: add namespace name pattern for registriesNamespace, allow empty string to replace with default value * fix: use unique webhook names * fix: don't change existing validating webhook name to avoid upgrade issues * feat: add model registry registriesNamespace in DSC status * update: - move ModelRegistryStatus from ModelReg into status - update validation rule for namespace: - when update is to removed/unmanaged modelreg: regardless previous state, can change name and set to removed - upgrade 2.13 to 2.14 when no NS set in 2.13 - when update is from remove/unmanaged: e.g change from removed to managed and change name at the same tie - keep same namespace, regardless state - reduce print on passed allowed webhook request - set to omitemptry so required is not add in the CSV - fix review comments: - move update status after reconcile is successful - set to use const for caching on ModeReg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit dd3df21) fix: only replace/set default model reg namespace by webhook if component is enabled - when modelreg is not set in DSC - when modelreg is set to be Removed these two cases should not block operation, for backwards compataible Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 03f6c0b)

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid double squashing due to merge policy. modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (opendatahub-io#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (opendatahub-io#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (opendatahub-io#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (opendatahub-io#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (opendatahub-io#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (opendatahub-io#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013) feat: add managed model registry prometheus job, metrics, and alering rules, fixes RHOAIENG-4273 (cherry picked from commit f811d67) modelregistry: partial: fix: add check for all platform offering on components Partial application of ab7e04e ("fix: add check for all platform offering on components (opendatahub-io#1205)") ModelRegistry related. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 (opendatahub-io#1221) * feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added registriesNamespace property in references to model registry component in docs, samples, etc. Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: updated api-overview.md Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: add missing field in setupDSCInstance() Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added debug log for failing e2e test * debug: added log messages in test dsc creation Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * debug: make registriesNamespace omitempty so apiserver will set the default value, clean testDSCCreation with more log messages Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * update: modelregistry with namespace - add namespace for rhoai case - remove omitemptry on namespace: if user does not set it, it will get default value to use. since its type is string Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: test need to update for modelreg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: cleanup debug info in test cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: make registriesNamespace immutability check dynamic in cel validation rule * fix: refactor validation rule, set registriesNamespace to optional, add patch func in modelregistry to set default value * fix: add defaulting webhook including envtest, remove patch from modelregistry component * fix: add namespace name pattern for registriesNamespace, allow empty string to replace with default value * fix: use unique webhook names * fix: don't change existing validating webhook name to avoid upgrade issues * feat: add model registry registriesNamespace in DSC status * update: - move ModelRegistryStatus from ModelReg into status - update validation rule for namespace: - when update is to removed/unmanaged modelreg: regardless previous state, can change name and set to removed - upgrade 2.13 to 2.14 when no NS set in 2.13 - when update is from remove/unmanaged: e.g change from removed to managed and change name at the same tie - keep same namespace, regardless state - reduce print on passed allowed webhook request - set to omitemptry so required is not add in the CSV - fix review comments: - move update status after reconcile is successful - set to use const for caching on ModeReg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit dd3df21) fix: only replace/set default model reg namespace by webhook if component is enabled - when modelreg is not set in DSC - when modelreg is set to be Removed these two cases should not block operation, for backwards compataible Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 03f6c0b) Update autogenerated files run `make generate manifests api-docs` Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid possible double squashing on merging. modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (opendatahub-io#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (opendatahub-io#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (opendatahub-io#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (opendatahub-io#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (opendatahub-io#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (opendatahub-io#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013) feat: add managed model registry prometheus job, metrics, and alering rules, fixes RHOAIENG-4273 (cherry picked from commit f811d67) modelregistry: partial: fix: add check for all platform offering on components Partial application of ab7e04e ("fix: add check for all platform offering on components (opendatahub-io#1205)") ModelRegistry related. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 (opendatahub-io#1221) * feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added registriesNamespace property in references to model registry component in docs, samples, etc. Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: updated api-overview.md Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: add missing field in setupDSCInstance() Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added debug log for failing e2e test * debug: added log messages in test dsc creation Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * debug: make registriesNamespace omitempty so apiserver will set the default value, clean testDSCCreation with more log messages Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * update: modelregistry with namespace - add namespace for rhoai case - remove omitemptry on namespace: if user does not set it, it will get default value to use. since its type is string Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: test need to update for modelreg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: cleanup debug info in test cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: make registriesNamespace immutability check dynamic in cel validation rule * fix: refactor validation rule, set registriesNamespace to optional, add patch func in modelregistry to set default value * fix: add defaulting webhook including envtest, remove patch from modelregistry component * fix: add namespace name pattern for registriesNamespace, allow empty string to replace with default value * fix: use unique webhook names * fix: don't change existing validating webhook name to avoid upgrade issues * feat: add model registry registriesNamespace in DSC status * update: - move ModelRegistryStatus from ModelReg into status - update validation rule for namespace: - when update is to removed/unmanaged modelreg: regardless previous state, can change name and set to removed - upgrade 2.13 to 2.14 when no NS set in 2.13 - when update is from remove/unmanaged: e.g change from removed to managed and change name at the same tie - keep same namespace, regardless state - reduce print on passed allowed webhook request - set to omitemptry so required is not add in the CSV - fix review comments: - move update status after reconcile is successful - set to use const for caching on ModeReg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit dd3df21) fix: only replace/set default model reg namespace by webhook if component is enabled - when modelreg is not set in DSC - when modelreg is set to be Removed these two cases should not block operation, for backwards compataible Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 03f6c0b) Update autogenerated files run `make generate manifests api-docs` Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: replace odh-model-registries with rhoai-model-registries Fix names of default registries namespace treewide. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> tests: e2e: disable modelregistry It is not GA yet, disable for now to avoid possible problems. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> get_all_manifests.sh: modelregistry: use rhoai-2.14 branch Use versioned branch/tag like other components. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid possible double squashing on merging. modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (opendatahub-io#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (opendatahub-io#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (opendatahub-io#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (opendatahub-io#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (opendatahub-io#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (opendatahub-io#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013) feat: add managed model registry prometheus job, metrics, and alering rules, fixes RHOAIENG-4273 (cherry picked from commit f811d67) modelregistry: partial: fix: add check for all platform offering on components Partial application of ab7e04e ("fix: add check for all platform offering on components (opendatahub-io#1205)") ModelRegistry related. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 (opendatahub-io#1221) * feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added registriesNamespace property in references to model registry component in docs, samples, etc. Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: updated api-overview.md Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: add missing field in setupDSCInstance() Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added debug log for failing e2e test * debug: added log messages in test dsc creation Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * debug: make registriesNamespace omitempty so apiserver will set the default value, clean testDSCCreation with more log messages Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * update: modelregistry with namespace - add namespace for rhoai case - remove omitemptry on namespace: if user does not set it, it will get default value to use. since its type is string Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: test need to update for modelreg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: cleanup debug info in test cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: make registriesNamespace immutability check dynamic in cel validation rule * fix: refactor validation rule, set registriesNamespace to optional, add patch func in modelregistry to set default value * fix: add defaulting webhook including envtest, remove patch from modelregistry component * fix: add namespace name pattern for registriesNamespace, allow empty string to replace with default value * fix: use unique webhook names * fix: don't change existing validating webhook name to avoid upgrade issues * feat: add model registry registriesNamespace in DSC status * update: - move ModelRegistryStatus from ModelReg into status - update validation rule for namespace: - when update is to removed/unmanaged modelreg: regardless previous state, can change name and set to removed - upgrade 2.13 to 2.14 when no NS set in 2.13 - when update is from remove/unmanaged: e.g change from removed to managed and change name at the same tie - keep same namespace, regardless state - reduce print on passed allowed webhook request - set to omitemptry so required is not add in the CSV - fix review comments: - move update status after reconcile is successful - set to use const for caching on ModeReg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit dd3df21) fix: only replace/set default model reg namespace by webhook if component is enabled - when modelreg is not set in DSC - when modelreg is set to be Removed these two cases should not block operation, for backwards compataible Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 03f6c0b) Update autogenerated files run `make generate manifests api-docs` Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: replace odh-model-registries with rhoai-model-registries Fix names of default registries namespace treewide. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> tests: e2e: disable modelregistry It is not GA yet, disable for now to avoid possible problems. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> get_all_manifests.sh: modelregistry: use rhoai-2.14 branch Use versioned branch/tag like other components. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> Revert "get_all_manifests.sh: modelregistry: use rhoai-2.14 branch" There is no yet rhoai-2.14 branch for modelregistry. This reverts commit 4c7d83a. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid possible double squashing on merging. modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (opendatahub-io#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (opendatahub-io#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (opendatahub-io#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (opendatahub-io#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (opendatahub-io#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (opendatahub-io#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013) feat: add managed model registry prometheus job, metrics, and alering rules, fixes RHOAIENG-4273 (cherry picked from commit f811d67) modelregistry: partial: fix: add check for all platform offering on components Partial application of ab7e04e ("fix: add check for all platform offering on components (opendatahub-io#1205)") ModelRegistry related. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 (opendatahub-io#1221) * feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added registriesNamespace property in references to model registry component in docs, samples, etc. Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: updated api-overview.md Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: add missing field in setupDSCInstance() Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added debug log for failing e2e test * debug: added log messages in test dsc creation Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * debug: make registriesNamespace omitempty so apiserver will set the default value, clean testDSCCreation with more log messages Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * update: modelregistry with namespace - add namespace for rhoai case - remove omitemptry on namespace: if user does not set it, it will get default value to use. since its type is string Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: test need to update for modelreg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: cleanup debug info in test cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: make registriesNamespace immutability check dynamic in cel validation rule * fix: refactor validation rule, set registriesNamespace to optional, add patch func in modelregistry to set default value * fix: add defaulting webhook including envtest, remove patch from modelregistry component * fix: add namespace name pattern for registriesNamespace, allow empty string to replace with default value * fix: use unique webhook names * fix: don't change existing validating webhook name to avoid upgrade issues * feat: add model registry registriesNamespace in DSC status * update: - move ModelRegistryStatus from ModelReg into status - update validation rule for namespace: - when update is to removed/unmanaged modelreg: regardless previous state, can change name and set to removed - upgrade 2.13 to 2.14 when no NS set in 2.13 - when update is from remove/unmanaged: e.g change from removed to managed and change name at the same tie - keep same namespace, regardless state - reduce print on passed allowed webhook request - set to omitemptry so required is not add in the CSV - fix review comments: - move update status after reconcile is successful - set to use const for caching on ModeReg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit dd3df21) fix: only replace/set default model reg namespace by webhook if component is enabled - when modelreg is not set in DSC - when modelreg is set to be Removed these two cases should not block operation, for backwards compataible Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 03f6c0b) Update autogenerated files run `make generate manifests api-docs` Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: replace odh-model-registries with rhoai-model-registries Fix names of default registries namespace treewide. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> tests: e2e: disable modelregistry It is not GA yet, disable for now to avoid possible problems. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> get_all_manifests.sh: modelregistry: use rhoai-2.14 branch Use versioned branch/tag like other components. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid possible double squashing on merging. Set management state to Removed since it is not modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (opendatahub-io#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (opendatahub-io#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (opendatahub-io#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (opendatahub-io#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (opendatahub-io#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (opendatahub-io#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013) feat: add managed model registry prometheus job, metrics, and alering rules, fixes RHOAIENG-4273 (cherry picked from commit f811d67) modelregistry: partial: fix: add check for all platform offering on components Partial application of ab7e04e ("fix: add check for all platform offering on components (opendatahub-io#1205)") ModelRegistry related. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 (opendatahub-io#1221) * feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added registriesNamespace property in references to model registry component in docs, samples, etc. Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: updated api-overview.md Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: add missing field in setupDSCInstance() Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added debug log for failing e2e test * debug: added log messages in test dsc creation Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * debug: make registriesNamespace omitempty so apiserver will set the default value, clean testDSCCreation with more log messages Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * update: modelregistry with namespace - add namespace for rhoai case - remove omitemptry on namespace: if user does not set it, it will get default value to use. since its type is string Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: test need to update for modelreg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: cleanup debug info in test cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: make registriesNamespace immutability check dynamic in cel validation rule * fix: refactor validation rule, set registriesNamespace to optional, add patch func in modelregistry to set default value * fix: add defaulting webhook including envtest, remove patch from modelregistry component * fix: add namespace name pattern for registriesNamespace, allow empty string to replace with default value * fix: use unique webhook names * fix: don't change existing validating webhook name to avoid upgrade issues * feat: add model registry registriesNamespace in DSC status * update: - move ModelRegistryStatus from ModelReg into status - update validation rule for namespace: - when update is to removed/unmanaged modelreg: regardless previous state, can change name and set to removed - upgrade 2.13 to 2.14 when no NS set in 2.13 - when update is from remove/unmanaged: e.g change from removed to managed and change name at the same tie - keep same namespace, regardless state - reduce print on passed allowed webhook request - set to omitemptry so required is not add in the CSV - fix review comments: - move update status after reconcile is successful - set to use const for caching on ModeReg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit dd3df21) fix: only replace/set default model reg namespace by webhook if component is enabled - when modelreg is not set in DSC - when modelreg is set to be Removed these two cases should not block operation, for backwards compataible Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 03f6c0b) Update autogenerated files run `make generate manifests api-docs` Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: replace odh-model-registries with rhoai-model-registries Fix names of default registries namespace treewide. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> tests: e2e: disable modelregistry It is not GA yet, disable for now to avoid possible problems. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> get_all_manifests.sh: modelregistry: use rhoai-2.14 branch Use versioned branch/tag like other components. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> Update config/samples/datasciencecluster_v1_datasciencecluster.yaml Co-authored-by: Wen Zhou <wenzhou@redhat.com> Update bundle/manifests/rhods-operator.clusterserviceversion.yaml Co-authored-by: Wen Zhou <wenzhou@redhat.com>

…o#776) Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid possible double squashing on merging. Set management state to Removed since it is not modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (opendatahub-io#775) (opendatahub-io#776) * feat: Add ModelRegistry component (opendatahub-io#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (opendatahub-io#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (opendatahub-io#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (opendatahub-io#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (opendatahub-io#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (opendatahub-io#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (opendatahub-io#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (opendatahub-io#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (opendatahub-io#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (opendatahub-io#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (opendatahub-io#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (opendatahub-io#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (opendatahub-io#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (opendatahub-io#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (opendatahub-io#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (opendatahub-io#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (opendatahub-io#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (opendatahub-io#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (opendatahub-io#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (opendatahub-io#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (opendatahub-io#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (opendatahub-io#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013) feat: add managed model registry prometheus job, metrics, and alering rules, fixes RHOAIENG-4273 (cherry picked from commit f811d67) modelregistry: partial: fix: add check for all platform offering on components Partial application of ab7e04e ("fix: add check for all platform offering on components (opendatahub-io#1205)") ModelRegistry related. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 (opendatahub-io#1221) * feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added registriesNamespace property in references to model registry component in docs, samples, etc. Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: updated api-overview.md Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: add missing field in setupDSCInstance() Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added debug log for failing e2e test * debug: added log messages in test dsc creation Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * debug: make registriesNamespace omitempty so apiserver will set the default value, clean testDSCCreation with more log messages Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * update: modelregistry with namespace - add namespace for rhoai case - remove omitemptry on namespace: if user does not set it, it will get default value to use. since its type is string Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: test need to update for modelreg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: cleanup debug info in test cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: make registriesNamespace immutability check dynamic in cel validation rule * fix: refactor validation rule, set registriesNamespace to optional, add patch func in modelregistry to set default value * fix: add defaulting webhook including envtest, remove patch from modelregistry component * fix: add namespace name pattern for registriesNamespace, allow empty string to replace with default value * fix: use unique webhook names * fix: don't change existing validating webhook name to avoid upgrade issues * feat: add model registry registriesNamespace in DSC status * update: - move ModelRegistryStatus from ModelReg into status - update validation rule for namespace: - when update is to removed/unmanaged modelreg: regardless previous state, can change name and set to removed - upgrade 2.13 to 2.14 when no NS set in 2.13 - when update is from remove/unmanaged: e.g change from removed to managed and change name at the same tie - keep same namespace, regardless state - reduce print on passed allowed webhook request - set to omitemptry so required is not add in the CSV - fix review comments: - move update status after reconcile is successful - set to use const for caching on ModeReg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit dd3df21) fix: only replace/set default model reg namespace by webhook if component is enabled - when modelreg is not set in DSC - when modelreg is set to be Removed these two cases should not block operation, for backwards compataible Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 03f6c0b) Update autogenerated files run `make generate manifests api-docs` Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: replace odh-model-registries with rhoai-model-registries Fix names of default registries namespace treewide. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> tests: e2e: disable modelregistry It is not GA yet, disable for now to avoid possible problems. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> get_all_manifests.sh: modelregistry: use rhoai-2.14 branch Use versioned branch/tag like other components. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> Update config/samples/datasciencecluster_v1_datasciencecluster.yaml Co-authored-by: Wen Zhou <wenzhou@redhat.com> Update bundle/manifests/rhods-operator.clusterserviceversion.yaml Co-authored-by: Wen Zhou <wenzhou@redhat.com> modelregistry: keep registriesNamespace as odh except CSV It makes less divergency with ODH and default does not matter as soon as CSV has RHOAI version. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

Squashed commit due to buildability since ComponentInterface has changed. Other patches squashed as well to avoid possible double squashing on merging. Set management state to Removed since it is not modelregistry: regenerate autogenerated files Run `make generate manifests` after all the changes Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: Add ModelRegistry component (#775) (#776) * feat: Add ModelRegistry component (#775) * fix: Fix modelregistry odh overlays path * fix: fix dsc_create_test tests err nil check * fix: refactor ModelRegistry.ReconcileComponent for new parameters * chore: added modelregistry to README.md * fix: add missing rbac rules for deploymentconfigs and daemonsets * chore: code lint cleanup * fix: added check for nil DevFlags in model-registry component * fix: add nil check for dscispec.DevFlags in model-registry ReconcileComponent * fix: remove RBAC rules for daemonsets and deploymentconfigs * fix(chore): fix lint errors in dsc_deletion_test.go (cherry picked from commit 112d3f1) Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: removes SetImageParamsMap from ComponentInterface (#897) Partial application of already applied commit d10a764 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Thu Mar 7 15:43:37 2024 +0100 chore: removes SetImageParamsMap from ComponentInterface (#897) As it's not used by any component, acting as a simple pass-return loop. This makes the API contract a bit cleaner. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove the need of passing rest config (#895) Partial application of already applied commit ca7fa98 Author: Bartosz Majsak <bartosz.majsak@gmail.com> Date: Fri Mar 8 17:40:54 2024 +0100 chore: remove the need of passing rest config (#895) * chore: fixes ComponentInterface docs By removing reference to non-existing func. This function has been in use outside of this component. * fix: removes rest config As we are already using client.Client interface we do not have to instantiate other typed clients to e.g. list resources using their own funcs. Generic client.Client is sufficient for these needs. Additionally this change adds ctx propogation for these calls. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: feat(logger): for both controller level and component level (#837) Partial application of already applied commit d8a83a2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Apr 1 22:06:16 2024 +0200 feat(logger): for both controller level and component level (#837) * feat(logger): for both controller level and component level Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update(logger): use logr instead of uber's zap Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: do not log error only print Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: use zap.Options for both and tune levels Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move setting into common function Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> update(modelregistry): rename image name (#877) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b4e4d6f) modelregistry: partial: chore: cleanup duplicated functions packages and add more for godoc (#981) Partial application of already applied commit 96c85f2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Apr 23 14:05:24 2024 +0200 chore: cleanup duplicated functions packages and add more for godoc (#981) * chore: cleanup duplicated functions/package and add godoc - move GetPlatform() from deploy package to cluster package - move const ManagedRhods SelfManagedRhods OpenDataHub from deploy to cluster package - move WaitForDeploymentAvailable() monitoring package to cluster package - remove monitoring package - move UpdatePodSecurityRolebinding() from common package to cluster package - deprecate GetDomain from common package, to only use GetDomain from cluster package. - remove gvk package, move its GVK to cluster package - move DeleteExistingSubscription() from deploy package to upgrade package - do not export getSubscription() Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove gvk into one file but under cluster package Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: rename variable, removing GVK from it Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: move gvk into a sub package under cluster Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat(mr): create namespace for Model Registry (#930) * feat(mr): create namespace for smm Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: rebase Signed-off-by: Zhou, Wen <wenzhou@redhat.com> * update: code review comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix(doc): wrong comments Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: remove label to keep namespace even opreator is uninstalled Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Zhou, Wen <wenzhou@redhat.com> (cherry picked from commit 1188ce1) feat(mr): add model registry odh extras manifests, fixes RHOAIENG-5112 (#953) (cherry picked from commit 7c3e81b) modelregistry: partial: chore: Open up util functions for context propagation (#1033) Partial application of already applied commit 105adae Author: Aslak Knutsen <aslak@4fs.no> Date: Tue Jun 4 15:16:21 2024 +0200 chore: Open up util functions for context propagation (#1033) context should be determined by the caller and propagated down the call chain. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore: remove duplicated platform call in each component (#1055) Partial application of already applied commit 1b04761 Author: Wen Zhou <wenzhou@redhat.com> Date: Fri Jun 14 14:47:33 2024 +0200 chore: remove duplicated platform call in each component (#1055) - get in DSC and pass into compoment Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: update api docs run `make api-docs` add +groupName=datasciencecluster.opendatahub.io On backporting of 1b86e42 ("Update readme.md (#890)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: partial: chore(lint): enable contextcheck and containedctx (#1070) Partial application of already applied: commit 06e21a4 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jun 25 17:15:13 2024 +0200 chore(lint): enable contextcheck and containedctx (#1070) * chore(lint): enable contextcheck Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * chore(lint): enable containedctx Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> * Fix PR review findings * Fix rebase --------- Signed-off-by: Luca Burgazzoli <lburgazzoli@gmail.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> refactor: dashboard with new manifests structure (#1065) Partial application of already applied: commit 438f4c2 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jul 2 16:56:25 2024 +0200 refactor: dashboard with new manifests structure (#1065) * refactor: dashboard with new manifests structure - change type of platform, skip convert to string - add more support for ApplyParam() to not only take ENV but also anything from ExtraParamMaps * update: simplify override function * update: add value for Unknown platform --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add managed model registry prometheus config handling logic, part of RHOAIENG-4273 (#1150) (cherry picked from commit 72fc80f) Adjusted Kueue and TrainingOperator rules Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: add default cert for model registry, fixes RHOAIENG-9909 (#1165) Conflicts: ApplyParams arguments due to missing: d84cd33 ("update: remove unnecessary param from ApplyParams() (#1180)") * feat: add default cert for model registry, fixes RHOAIENG-9909 * fix: fixed lint errors * fix: add servicemesh feature check for MR, add MR enable check in e2e default cert test * fix: changed MR servicemesh status check to look for Managed state * fix: ignore missing model-registry default cert if already removed (cherry picked from commit 4c411a6) feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 (#1202) * feat: add servicemeshmember for model registry namespace, fixes RHOAIENG-11831 * fix: ignore error if MR smm already exists * code cleanup for readability Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Avoid shadowing package name in variable Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: rename createServicemeshMember to enrollToServiceMesh, add log messages --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 8f3d013) feat: add managed model registry prometheus job, metrics, and alering rules, fixes RHOAIENG-4273 (cherry picked from commit f811d67) modelregistry: partial: fix: add check for all platform offering on components Partial application of ab7e04e ("fix: add check for all platform offering on components (#1205)") ModelRegistry related. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 (#1221) * feat: added shared registries namespace property in model registry dsc component, fixes RHOAIENG-12335 Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added registriesNamespace property in references to model registry component in docs, samples, etc. Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: updated api-overview.md Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: add missing field in setupDSCInstance() Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * fix: added debug log for failing e2e test * debug: added log messages in test dsc creation Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * debug: make registriesNamespace omitempty so apiserver will set the default value, clean testDSCCreation with more log messages Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> * update: modelregistry with namespace - add namespace for rhoai case - remove omitemptry on namespace: if user does not set it, it will get default value to use. since its type is string Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: test need to update for modelreg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: cleanup debug info in test cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: make registriesNamespace immutability check dynamic in cel validation rule * fix: refactor validation rule, set registriesNamespace to optional, add patch func in modelregistry to set default value * fix: add defaulting webhook including envtest, remove patch from modelregistry component * fix: add namespace name pattern for registriesNamespace, allow empty string to replace with default value * fix: use unique webhook names * fix: don't change existing validating webhook name to avoid upgrade issues * feat: add model registry registriesNamespace in DSC status * update: - move ModelRegistryStatus from ModelReg into status - update validation rule for namespace: - when update is to removed/unmanaged modelreg: regardless previous state, can change name and set to removed - upgrade 2.13 to 2.14 when no NS set in 2.13 - when update is from remove/unmanaged: e.g change from removed to managed and change name at the same tie - keep same namespace, regardless state - reduce print on passed allowed webhook request - set to omitemptry so required is not add in the CSV - fix review comments: - move update status after reconcile is successful - set to use const for caching on ModeReg namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Dhiraj Bokde <dhirajsb@users.noreply.github.com> Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit dd3df21) fix: only replace/set default model reg namespace by webhook if component is enabled - when modelreg is not set in DSC - when modelreg is set to be Removed these two cases should not block operation, for backwards compataible Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 03f6c0b) Update autogenerated files run `make generate manifests api-docs` Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> modelregistry: replace odh-model-registries with rhoai-model-registries Fix names of default registries namespace treewide. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> tests: e2e: disable modelregistry It is not GA yet, disable for now to avoid possible problems. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> get_all_manifests.sh: modelregistry: use rhoai-2.14 branch Use versioned branch/tag like other components. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> Update config/samples/datasciencecluster_v1_datasciencecluster.yaml Co-authored-by: Wen Zhou <wenzhou@redhat.com> Update bundle/manifests/rhods-operator.clusterserviceversion.yaml Co-authored-by: Wen Zhou <wenzhou@redhat.com> modelregistry: keep registriesNamespace as odh except CSV It makes less divergency with ODH and default does not matter as soon as CSV has RHOAI version. Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

openshift-ci bot requested review from aslakknutsen and dhirajsb March 5, 2024 10:40

aslakknutsen reviewed Mar 5, 2024

View reviewed changes

AjayJagan force-pushed the update-readme branch from 6e35296 to dbc076e Compare March 5, 2024 10:47

AjayJagan requested a review from VaishnaviHire March 5, 2024 10:53

AjayJagan force-pushed the update-readme branch from 1f2e415 to e7b7c99 Compare March 5, 2024 11:19

AjayJagan force-pushed the update-readme branch 3 times, most recently from 902574d to f8c4b9a Compare March 7, 2024 08:03

bartoszmajsak reviewed Mar 7, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

bartoszmajsak reviewed Mar 7, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

bartoszmajsak reviewed Mar 7, 2024

View reviewed changes

crd-ref-docs.config.yaml Outdated Show resolved Hide resolved

AjayJagan force-pushed the update-readme branch from f8c4b9a to 733a8a1 Compare March 7, 2024 12:02

VaishnaviHire added the odh-2.9 label Mar 7, 2024

VaishnaviHire reviewed Mar 7, 2024

View reviewed changes

openshift-merge-robot added the needs-rebase label Mar 7, 2024

AjayJagan force-pushed the update-readme branch from 41b1cc3 to 3ad878b Compare March 7, 2024 16:58

openshift-merge-robot removed the needs-rebase label Mar 7, 2024

VaishnaviHire removed the request for review from dhirajsb March 7, 2024 18:05

AjayJagan force-pushed the update-readme branch 2 times, most recently from 87b08f3 to 52b6c9d Compare March 8, 2024 10:58

AjayJagan added 2 commits March 8, 2024 17:16

Update readme.md

cf846cd

update links to the respective schemas

574c17a

openshift-ci bot assigned VaishnaviHire Mar 8, 2024

openshift-ci bot added the lgtm label Mar 8, 2024

zdtsw approved these changes Mar 9, 2024

View reviewed changes

openshift-ci bot assigned zdtsw Mar 9, 2024

openshift-ci bot added the approved label Mar 9, 2024

VaishnaviHire merged commit 1b86e42 into opendatahub-io:incubation Mar 11, 2024
6 of 7 checks passed

AjayJagan mentioned this pull request Mar 13, 2024

feat(gh-action): ensures generated files are up-to-date in PR #917

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update readme.md #890

Update readme.md #890

AjayJagan commented Mar 5, 2024

aslakknutsen Mar 5, 2024

AjayJagan Mar 5, 2024

AjayJagan Mar 5, 2024

aslakknutsen Mar 5, 2024

AjayJagan Mar 5, 2024

aslakknutsen Mar 7, 2024

aslakknutsen Mar 7, 2024

AjayJagan Mar 7, 2024

bartoszmajsak Mar 7, 2024 •

edited

Loading

AjayJagan Mar 7, 2024

zdtsw commented Mar 6, 2024

AjayJagan commented Mar 6, 2024

bartoszmajsak commented Mar 7, 2024

AjayJagan commented Mar 7, 2024

bartoszmajsak commented Mar 7, 2024

AjayJagan commented Mar 7, 2024

VaishnaviHire Mar 7, 2024

VaishnaviHire Mar 7, 2024

VaishnaviHire commented Mar 8, 2024

openshift-ci bot commented Mar 9, 2024

		@@ -63,12 +83,12 @@ Refer [Dev-Preview.md](./docs/Dev-Preview.md) for testing preview features.

Update readme.md #890

Update readme.md #890

Conversation

AjayJagan commented Mar 5, 2024

Description

Merge criteria:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bartoszmajsak Mar 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zdtsw commented Mar 6, 2024

AjayJagan commented Mar 6, 2024

bartoszmajsak commented Mar 7, 2024

AjayJagan commented Mar 7, 2024

bartoszmajsak commented Mar 7, 2024

AjayJagan commented Mar 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VaishnaviHire commented Mar 8, 2024

openshift-ci bot commented Mar 9, 2024

bartoszmajsak Mar 7, 2024 •

edited

Loading