Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: version number and add description #388

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jul 30, 2023

Description

Just to fix version number overwritten by previous commit
also add description for codeflare/ray

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@zdtsw zdtsw requested a review from etirelli July 30, 2023 10:00
@openshift-ci openshift-ci bot requested review from LaVLaS and VaishnaviHire July 30, 2023 10:00
@zdtsw zdtsw removed the request for review from LaVLaS July 31, 2023 06:24
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw mentioned this pull request Jul 31, 2023
3 tasks
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 76ee489 into opendatahub-io:feature-rearchitecture Jul 31, 2023
VaishnaviHire added a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Jul 31, 2023
Add ODHDashboardconfig in dasboard component

(cherry picked from commit 2a8757d)

Add admin group for downstream

(cherry picked from commit 8a72ab9)

Add ImageParams for kuberay and codeflare

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit ab2fdab)

Add consolelink for new operator only on cloudserver cluster

- Move from util to common for ReplaceStringsInFile

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 80c69bb)

Fix: version number and add description (opendatahub-io#388)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 76ee489)

Add ImageParams map for KServe

- explainer images will later be removed and function move to trustyai

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 499d9e5)

Update labels

(cherry picked from commit a9b474f)

Shared resources should not be deleted

(cherry picked from commit 8739f65)

Remove dependency of deployment manifests on other components (opendatahub-io#387)

(cherry picked from commit 7a3a9f7)
VaishnaviHire added a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Jul 31, 2023
Add ODHDashboardconfig in dasboard component

(cherry picked from commit 2a8757d)

Add admin group for downstream

(cherry picked from commit 8a72ab9)

Add ImageParams for kuberay and codeflare

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit ab2fdab)

Add consolelink for new operator only on cloudserver cluster

- Move from util to common for ReplaceStringsInFile

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 80c69bb)

Fix: version number and add description (opendatahub-io#388)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 76ee489)

Add ImageParams map for KServe

- explainer images will later be removed and function move to trustyai

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 499d9e5)

Update labels

(cherry picked from commit a9b474f)

Shared resources should not be deleted

(cherry picked from commit 8739f65)

Remove dependency of deployment manifests on other components (opendatahub-io#387)

(cherry picked from commit 7a3a9f7)
(cherry picked from commit 39c91d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants