Skip to content

Commit

Permalink
Fix: version number and add description
Browse files Browse the repository at this point in the history
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
  • Loading branch information
zdtsw committed Jul 30, 2023
1 parent 7177253 commit ddfd812
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 13 deletions.
6 changes: 4 additions & 2 deletions apis/datasciencecluster/v1alpha1/datasciencecluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,12 @@ type Components struct {
// Kserve component configuration
Kserve kserve.Kserve `json:"kserve,omitempty"`

// CodeFlare component configuration
// CodeFlare component configuration.
// Require CodeFlare operator to be installed before enable component
CodeFlare codeflare.CodeFlare `json:"codeflare,omitempty"`

// Ray component configuration
// Ray component configuration.
// Require CodeFlare operator to be installed before enable component
Ray ray.Ray `json:"ray,omitempty"`
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ spec:
description: Override and fine tune specific component configurations.
properties:
codeflare:
description: CodeFlare component configuration
description: CodeFlare component configuration Require CodeFlare
operator to be installed before enable component
properties:
enabled:
description: Set to "true" to enable component, "false" to
Expand Down Expand Up @@ -89,7 +90,8 @@ spec:
- enabled
type: object
ray:
description: Ray component configuration
description: Ray component configuration Require CodeFlare operator
to be installed before enable component
properties:
enabled:
description: Set to "true" to enable component, "false" to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ metadata:
"kind": "OdhQuickStart",
"metadata": {
"annotations": {
"internal.config.kubernetes.io/previousKinds": "OdhQuickStart",
"internal.config.kubernetes.io/previousNames": "create-jupyter-notebook",
"internal.config.kubernetes.io/previousNamespaces": "default",
"opendatahub.io/categories": "Getting started,Notebook environments"
},
"labels": {
Expand Down Expand Up @@ -173,7 +170,7 @@ metadata:
operators.operatorframework.io/internal-objects: '[dscinitialization.opendatahub.io]'
operators.operatorframework.io/project_layout: go.kubebuilder.io/v3
repository: https://github.com/opendatahub-io/opendatahub-operator
name: opendatahub-operator.v0.0.6
name: opendatahub-operator.v2.0.0
namespace: placeholder
spec:
apiservicedefinitions: {}
Expand Down Expand Up @@ -420,7 +417,7 @@ spec:
- --leader-elect
command:
- /manager
image: quay.io/etirelli/opendatahub-operator:dev-0.0.6
image: REPLACE_IMAGE:latest
imagePullPolicy: Always
livenessProbe:
httpGet:
Expand Down Expand Up @@ -512,4 +509,4 @@ spec:
maturity: alpha
provider:
name: ODH
version: 0.0.6
version: 2.0.0
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ spec:
description: Override and fine tune specific component configurations.
properties:
codeflare:
description: CodeFlare component configuration
description: CodeFlare component configuration Require CodeFlare
operator to be installed before enable component
properties:
enabled:
description: Set to "true" to enable component, "false" to
Expand Down Expand Up @@ -90,7 +91,8 @@ spec:
- enabled
type: object
ray:
description: Ray component configuration
description: Ray component configuration Require CodeFlare operator
to be installed before enable component
properties:
enabled:
description: Set to "true" to enable component, "false" to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ func (r *DataScienceClusterReconciler) Reconcile(ctx context.Context, req ctrl.R
}
}

// // Ensure all ommited components show up as explicitly disabled
// // Ensure all omitted components show up as explicitly disabled
// instance, err = r.updateComponents(instance)
// if err != nil {
// _ = r.reportError(err, instance, "error updating list of components in the CR")
Expand Down

0 comments on commit ddfd812

Please sign in to comment.