Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes for operator and odh-manifests e2e tests #218

Merged

Conversation

VaishnaviHire
Copy link
Member

@VaishnaviHire VaishnaviHire commented Apr 5, 2023

This PR includes changes specific to e2e tests:

  • Update resource creation timeout for CI environment
  • Remove Kfdef Annotation tests as we moved to Ownerreferences
  • Remove ownerreferences from Subscription resource (This is required for allowing operator installs for DSP tests)

Resolves:

  • Test failures in openshift-ci

This commit updates resource creation timout for CI. It also replaces annotation tests with
ownerreferences
@openshift-ci openshift-ci bot requested review from anishasthana and LaVLaS April 5, 2023 14:06
@VaishnaviHire
Copy link
Member Author

/retest

@VaishnaviHire
Copy link
Member Author

/test opendatahub-operator-pr-image-mirror

We have deployments like datascience pipelines that rely on adding subscription to other
namespaces than the kfdef. Remove cross-namespace reference ownerreference
@VaishnaviHire VaishnaviHire changed the title Update e2e tests Add fixes for operator and odh-manifests e2e tests Apr 6, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

@VaishnaviHire: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-e2e def975f link true /test operator-e2e
ci/prow/unit-tests def975f link true /test unit-tests
ci/prow/opendatahub-manifests-e2e ca16b47 link false /test opendatahub-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LaVLaS
Copy link
Contributor

LaVLaS commented Apr 6, 2023

/approve

Changes look good to me

@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaVLaS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit 622bbd9 into opendatahub-io:master Apr 6, 2023
VaishnaviHire added a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Mar 19, 2024
)

* feat(cleanup): remove jupyterhub CR from previous release (opendatahub-io#871)

* feat(cleanup): remove jupyterhub CR from previous release

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

* fix: do not Exit if cleanup funciton failed

* Update pkg/upgrade/upgrade.go

Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>

* Fix cleanup of ODHApplications (opendatahub-io#914)

* fix(sync): after revert webhook in downstream, need re-import packages

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

---------

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com>
Co-authored-by: Vaishnavi Hire <vhire@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants