Fix cleanup of ODHApplications #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de0774d to
2153f12
Compare
zdtsw
approved these changes
Mar 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test opendatahub-operator-e2e |
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Mar 12, 2024
zdtsw
referenced
this pull request
in red-hat-data-services/rhods-operator
Mar 12, 2024
* feat(cleanup): remove jupyterhub CR from previous release (#871) * feat(cleanup): remove jupyterhub CR from previous release Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: do not Exit if cleanup funciton failed * Update pkg/upgrade/upgrade.go Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * Fix cleanup of ODHApplications (#914) * fix(sync): after revert webhook in downstream, need re-import packages Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Vaishnavi Hire <vhire@redhat.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On upgrade, odhApplications do not get cleaned up and the operator pod throws following error
Will include this in odh-2.9 release branch
Description
How Has This Been Tested?
Merge criteria: