-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to sync dashboard crds automatically #205
Add workflow to sync dashboard crds automatically #205
Conversation
Skipping CI for Draft Pull Request. |
d45c445
to
1a89454
Compare
1a89454
to
8555790
Compare
run: | | ||
cd ${{ github.workspace }}/config/crd/dashboard-crds | ||
svn checkout --force https://github.com/opendatahub-io/odh-dashboard/branches/main/manifests/crd | ||
svn revert -R ./crd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maroroman Not exactly sure on how the svn revert
command working here? Is it reverting any uncommited changes?
Can we instead just remove the existing version of crds and replace them with odh-dashboard/branches/main/manifests/crd
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what the command should do, as far as I know, when I looked it up and tested it the revert command with the -R argument "reverts" the state of the folder to whatever has been checked out. So this basically overwrites whatever is in the crd folder with the crd changes in the dashboard.
Edit: There is also svn update
, as shown here: https://stackoverflow.com/questions/36383634/svn-overwrite-a-specific-file-from-svn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I replaced the checkout and revert command with a better svn export
command. I have verified that it works locally. Could you please retry your test @VaishnaviHire?
10ca2c7
to
54127cb
Compare
8555790
to
166d22b
Compare
166d22b
to
02487c4
Compare
02487c4
to
5a00c2b
Compare
/lgtm |
/retest |
@maroroman: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VaishnaviHire The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…revert Revert "DSC, DSCI: add validating webhook (opendatahub-io#711)"
Resolves: #200
Prerequisite: opendatahub-io/odh-dashboard#996
Description
This PR awaits a dispatch from another workflow (https://github.com/maroroman/odh-dashboard/blob/239d23cd54addf29b88789d7a0b38f9a4dcc6313/.github/workflows/dispatch_on_crd_change.yaml) in the odh-dashboard repo and automatically creates a PR with these changes.
How Has This Been Tested?
This PR was tested using https://github.com/nektos/act to locally verify that the workflow is sending the dispatch correctly.
To test this in real conditions, a fork of the operator and dashboard is required:
Merge criteria: