-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github dispatch for operator sync workflow #996
Add github dispatch for operator sync workflow #996
Conversation
Just a sidenote, I am still trying to make this work with my forks, but locally the command is fine, so it should work in real conditions as long as the trigger is correct. |
How do we test this @maroroman ? @VaishnaviHire / @LaVLaS |
@andrewballantyne I verified that the dispatch works and is received by the operator (my fork of it) through the utility I mentioned in the test description. To test the trigger it could be used as well or we can use some forks through the steps I wrote. I had trouble with those forks but that trigger is (as far as I know) exactly as the documentation states, so it should work :D |
Can we have more context, this is handle by the deployer downstream, are we moving away from that these files? Is this only targeted to upstream? Just to make sure we then disable it downstream. |
Based on a conversation with @VaishnaviHire this should only be targeted at upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @LaVLaS @VaishnaviHire
@LaVLaS or @VaishnaviHire please approve this before we will merge it.
This is a github action and I don't mind the inclusion in the dashboard repo, but this is not for our dashboard effort so I need someone from the manifests team to approve this functionality.
The checkout action works, I've tested it locally to other repo (didn't want to break anything in the operator repo) and it's working. @LaVLaS @VaishnaviHire if you can validate and greenlight this we can review it and merge it. |
Sorry for the delay. Yes this looks good, we can merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @andrewballantyne |
Prerequisite for: opendatahub-io/opendatahub-operator#205
Description
This workflow sends a dispatch whenever a pull request is merged that modifies the crd folder of the dashboard repository. The operator has a workflow that then copies these changes automatically.
How Has This Been Tested?
This PR was tested using https://github.com/nektos/act to locally verify that the workflow is sending the dispatch correctly.
To test this in real conditions, a fork of the operator and dashboard is required:
Test Impact
No tests are done for github workflows (afaik)
Request review criteria: