-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: ensures tests are run on push #1236
ci: ensures tests are run on push #1236
Conversation
Unit tests job is currently only executed on PRs, leaving pushes on e.g. incubation branch untested. This can lead to issues like the one described in opendatahub-io#1235 This PR enables GH Action to be run also for push events.
Put a "on hold" label, so we can have some disucssion before merge this change. |
this is also related to "#1221 (comment)" |
Should the workflow just filter by branch? |
Co-authored-by: Wen Zhou <wenzhou@redhat.com>
adds missing trailing colon
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta, zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5d51806
into
opendatahub-io:incubation
Description
Unit tests job is currently only executed on PRs, leaving pushes on e.g. incubation branch untested. This can lead to issues like the one described in #1235
This PR enables GH Action to be run also for push events.
How Has This Been Tested?
You can use
act
to test GH Actions locally instead of running them on your fork.act "on: push" -j unit-test -P ubuntu-latest=ghcr.io/catthehacker/ubuntu:act-latest
Screenshot or short clip
Merge criteria