fix(test): makes DSCI-dependent tests self-contained #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures each tests uses different DSCI instance as a test fixture. Without this tests are failing (as they do in latest incubation commit), as opendatahub-io#1222 introduced validation check to ensure AppNamespace is immutable, but opendatahub-io#1228 is trying to update DSCI violating new constraint. With this change each test uses dedicated DSCI.
9ad6476 to
18d85af
Compare
5 tasks
zdtsw
approved these changes
Sep 14, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
df1add0
into
opendatahub-io:incubation
8 checks passed
bartoszmajsak
added a commit
to bartoszmajsak/opendatahub-operator
that referenced
this pull request
Sep 14, 2024
Unit tests job is currently only executed on PRs, leaving pushes on e.g. incubation branch untested. This can lead to issues like the one described in opendatahub-io#1235 This PR enables GH Action to be run also for push events.
5 tasks
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Sep 16, 2024
…1235) Ensures each tests uses different DSCI instance as a test fixture. Without this tests are failing (as they do in latest incubation commit), as opendatahub-io#1222 introduced validation check to ensure AppNamespace is immutable, but opendatahub-io#1228 is trying to update DSCI violating new constraint. With this change each test uses dedicated DSCI. (cherry picked from commit df1add0)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Sep 16, 2024
…1235) Ensures each tests uses different DSCI instance as a test fixture. Without this tests are failing (as they do in latest incubation commit), as opendatahub-io#1222 introduced validation check to ensure AppNamespace is immutable, but opendatahub-io#1228 is trying to update DSCI violating new constraint. With this change each test uses dedicated DSCI. (cherry picked from commit df1add0)
openshift-merge-bot bot
referenced
this pull request
in red-hat-data-services/rhods-operator
Sep 18, 2024
Ensures each tests uses different DSCI instance as a test fixture. Without this tests are failing (as they do in latest incubation commit), as #1222 introduced validation check to ensure AppNamespace is immutable, but #1228 is trying to update DSCI violating new constraint. With this change each test uses dedicated DSCI. (cherry picked from commit df1add0)
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
* ci: ensures tests are run on push Unit tests job is currently only executed on PRs, leaving pushes on e.g. incubation branch untested. This can lead to issues like the one described in #1235 This PR enables GH Action to be run also for push events. * ci: limit branches for push events Co-authored-by: Wen Zhou <wenzhou@redhat.com> * fix(gh-action): correct use of pull_request element adds missing trailing colon --------- Co-authored-by: Wen Zhou <wenzhou@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures each test uses a different DSCI instance as a test fixture. Without this change, tests are failing (as they do in the latest incubation commit). The reason is #1222 that introduced a validation check to ensure
AppNamespaceis immutable, but #1228 is trying to update DSCI violating the new constraint. The issue is that #1228 was merged first and only then #1222 came in, but without being first rebased on top ofincubation.With this change, each test uses a dedicated DSCI.
Important
This issue was not caught earlier for two reasons:
incubationbefore merged.incubationdo not trigger test jobs.With this we ended up with #1228 merged first and #1222 being behind was merged afterwards without triggering the jobs. In conjunction, it results in failing
make testagainst latestincubation.Ideally we should ensure both mentioned weaknesses are addressed.
How Has This Been Tested?
Screenshot or short clip
Merge criteria