chore: remove dead code #1203
Merged
chore: remove dead code #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about createOdhNamespace() calls? |
i will clean the 2nd one as well. |
- the same code has been called up in the Reconcile() - for both DSCI status and appl. namespace creation Signed-off-by: Wen Zhou <wenzhou@redhat.com>
ykaliuta
approved these changes
Aug 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ykaliuta
reviewed
Aug 29, 2024
| @@ -144,15 +144,15 @@ func (r *DSCInitializationReconciler) Reconcile(ctx context.Context, req ctrl.Re | |||
| saved.Status.Phase = status.PhaseProgressing | |||
| }) | |||
| if err != nil { | |||
| r.Log.Error(err, "Failed to add conditions to status of DSCInitialization resource.", "DSCInitialization Request.Name", req.Name) | |||
| r.Log.Error(err, "Failed to add conditions to status of DSCInitialization resource.", "DSCInitialization", req.Namespace, "Request.Name", req.Name) | |||
There was a problem hiding this comment.
yeah, when removed the duplicated one, saw it has better logging than the kept one, so i just use it instead
zdtsw
referenced
this pull request
in zdtsw-forking/rhods-operator
Aug 30, 2024
- the same code has been called up in the Reconcile() - for both DSCI status and appl. namespace creation Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 1a8ce2c)
zdtsw
referenced
this pull request
in red-hat-data-services/rhods-operator
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/opendatahub-io/opendatahub-operator/blame/778ca9962ed79313cb389ba2772c5fd21ebb97ec/controllers/dscinitialization/dscinitialization_controller.go#L138
How Has This Been Tested?
Screenshot or short clip
Merge criteria