Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] chore: remove dead code (#1203) #339

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Aug 30, 2024

Description

  • the same code has been called up in the Reconcile()
  • for both DSCI status and appl. namespace creation

Signed-off-by: Wen Zhou wenzhou@redhat.com
(cherry picked from commit 1a8ce2c)

part of https://issues.redhat.com/browse/RHOAIENG-11883

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- the same code has been called up in the Reconcile()
- for both DSCI status and appl. namespace creation

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 1a8ce2c)
Copy link

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw
Copy link
Author

zdtsw commented Aug 30, 2024

/test rhods-operator-e2e

@zdtsw
Copy link
Author

zdtsw commented Aug 30, 2024

/test rhods-operator-e2e

@zdtsw zdtsw requested a review from VaishnaviHire August 30, 2024 11:40
@VaishnaviHire
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 30, 2024
@zdtsw zdtsw merged commit 5e0af82 into red-hat-data-services:main Aug 30, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants