RHOAIENG-15772: tests(odh-nbc): disable graceful shutdown period for envtest #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…envtest There is no benefit to doing graceful shutdown. We don't assert anything about the shutdown process, so it is best to be done with it quickly, so that we don't waste time and also avoid some meaningless log messages the shutdown may print out.
|
Not sure whether there may be some side effects TBH. But the tests seem to be happy, so /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9e32dfd
into
opendatahub-io:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-15772
Related to
Description
There is no benefit to doing graceful shutdown. We don't assert anything about the shutdown process, so it is best to be done with it quickly, so that we don't waste time and also avoid some meaningless log messages the shutdown may print out.
How Has This Been Tested?
Merge criteria: