RHOAIENG-15772: tests(odh-nbc): disable graceful shutdown period for …

…envtest (#464)

* RHOAIENG-15772: tests(odh-nbc): disable graceful shutdown period for envtest

There is no benefit to doing graceful shutdown. We don't assert anything about the shutdown process, so it is best to be done with it quickly, so that we don't waste time and also avoid some meaningless log messages the shutdown may print out.

* fixup also pass in test context

components/odh-notebook-controller/controllers/suite_test.go

@@ -18,6 +18,7 @@ import (
 	"context"
 	"crypto/tls"
 	"fmt"
+	"k8s.io/utils/ptr"
 	"net"
 	"path/filepath"
 	"testing"
@@ -127,6 +128,12 @@ var _ = BeforeSuite(func() {
 			Port:    webhookInstallOptions.LocalServingPort,
 			CertDir: webhookInstallOptions.LocalServingCertDir,
 		}),
+		// Issue#429: waiting in tests only wastes time and prints pointless context-cancelled errors
+		GracefulShutdownTimeout: ptr.To(time.Duration(0)),
+		// pass in test context because why not
+		BaseContext: func() context.Context {
+			return ctx
+		},
 	})
 	Expect(err).NotTo(HaveOccurred())