-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync v1.9-branch branch with main branch #444
Sync v1.9-branch branch with main branch #444
Conversation
…65869 [GHA] Update odh and notebook-controller with image main-648689f
[RHOAIENG-14687] Extend tests for certificate to assure that they are readable
…oauth-proxy image digest reference from 4.8 to the latest 4.14 version (opendatahub-io#388)""
…jd_revert_oauth_proxy_update RHOAIENG-14552: Reapply "RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version (opendatahub-io#388)"
…on_create RHOAIENG-15335: feat(odh-nbc/webhook): only update oauth-proxy image in CREATE events
* Introduce rolebinding controller to handle rbacs * Use SET_PIPELINE_RBAC configuration env * Skip tests if SET_PIPELINE_RBAC is set to false * Remove configmap and use a simple env in odh managers deployment * Swap deletion before creation on rbac controller * Add log error in case of error on the rbac reconciler * Set proper the ownerReferences when we create a rolebinding
All changes are in, the tests pass as well apart of the /override ci/prow/odh-notebook-controller-e2e |
@atheo89: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/odh-notebook-controller-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atheo89 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
8369940
into
opendatahub-io:v1.9-branch
fix for: #443
Description
How Has This Been Tested?
Merge criteria: