Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync v1.9-branch branch with main branch #444

Merged
merged 10 commits into from
Nov 7, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Nov 7, 2024

fix for: #443

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

github-actions bot and others added 10 commits October 18, 2024 08:49
…65869

[GHA] Update odh and notebook-controller with image main-648689f
[RHOAIENG-14687] Extend tests for certificate to assure that they are readable
…oauth-proxy image digest reference from 4.8 to the latest 4.14 version (opendatahub-io#388)""
…jd_revert_oauth_proxy_update

RHOAIENG-14552: Reapply "RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version (opendatahub-io#388)"
…on_create

RHOAIENG-15335: feat(odh-nbc/webhook): only update oauth-proxy image in CREATE events
* Introduce rolebinding controller to handle rbacs

* Use SET_PIPELINE_RBAC configuration env

* Skip tests if SET_PIPELINE_RBAC is set to false

* Remove configmap and use a simple env in odh managers deployment

* Swap deletion before creation on rbac controller

* Add log error in case of error on the rbac reconciler

* Set proper the ownerReferences when we create a rolebinding
@atheo89
Copy link
Member Author

atheo89 commented Nov 7, 2024

All changes are in, the tests pass as well apart of the e2e because of infra issue.

/override ci/prow/odh-notebook-controller-e2e
/lgtm
/approve

Copy link

openshift-ci bot commented Nov 7, 2024

@atheo89: you cannot LGTM your own PR.

In response to this:

All changes are in, the tests pass as well apart of the e2e because of infra issue.

/override ci/prow/odh-notebook-controller-e2e
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Nov 7, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/odh-notebook-controller-e2e

In response to this:

All changes are in, the tests pass as well apart of the e2e because of infra issue.

/override ci/prow/odh-notebook-controller-e2e
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2024
@jiridanek
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8369940 into opendatahub-io:v1.9-branch Nov 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants