Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync v1.9-branch branch with main branch #443

Closed
wants to merge 9 commits into from
Closed

Sync v1.9-branch branch with main branch #443

wants to merge 9 commits into from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 7, 2024

🤖 This is an automated Pull Request created by /.github/workflows/sync-branches-through-pr.yml.

It merges all commits from main branch into v1.9-branch branch.

⚠️ IMPORTANT NOTE: Remember to delete the sync__main__v1.9-branch__20241107092448 branch after merging the changes.

github-actions bot and others added 9 commits October 18, 2024 08:49
@github-actions
Update odh and notebook-controller with image main-648689f
5d61120
@openshift-merge-bot
Merge pull request #426 from opendatahub-io/temp-11400565869
6e20d78 
[GHA] Update odh and notebook-controller with image main-648689f
@jstourac
[RHOAIENG-14687] Extend tests for certificate to assure that they are…
9117408 
… readable

https://issues.redhat.com/browse/RHOAIENG-14687
@openshift-merge-bot
Merge pull request #435 from jstourac/RHOAIENG-14687
ad75ae8 
[RHOAIENG-14687] Extend tests for certificate to assure that they are readable
@jiridanek
RHOAIENG-15335: feat(odh-nbc/webhook): only update oauth-proxy image …
4a185e0 
…in CREATE events
@jiridanek
Revert "Revert "[v1.9-branch] RHOAIENG-10827: feat(nbcs): update ose-…
900f028 
…oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)""
@openshift-merge-bot
Merge pull request #439 from opendatahub-io/revert-419-jd_revert_oaut…
c210f7a 
…h_proxy_update

RHOAIENG-14552: Reapply "RHOAIENG-10827: feat(nbcs): update ose-oauth-proxy image digest reference from 4.8 to the latest 4.14 version (#388)"
@openshift-merge-bot
Merge pull request #437 from jiridanek/jd_update_oauth_on_create
9d606be 
RHOAIENG-15335: feat(odh-nbc/webhook): only update oauth-proxy image in CREATE events
@atheo89
Introduce rbac controller to handle RoleBindings (#434)
3f931d2 
* Introduce rolebinding controller to handle rbacs

* Use SET_PIPELINE_RBAC configuration env

* Skip tests if SET_PIPELINE_RBAC is set to false

* Remove configmap and use a simple env in odh managers deployment

* Swap deletion before creation on rbac controller

* Add log error in case of error on the rbac reconciler

* Set proper the ownerReferences when we create a rolebinding
@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 November 7, 2024 09:24
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2024

Hi @github-actions[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase The PR needs a rebase or there are conflicts label Nov 7, 2024
@atheo89 atheo89 mentioned this pull request Nov 7, 2024
Merged
3 tasks
@atheo89
Copy link
Member

atheo89 commented Nov 7, 2024

Open a manual pr to resolve the conflicts: #444 closing this

@atheo89 atheo89 closed this Nov 7, 2024
@jiridanek jiridanek deleted the sync__main__v1.9-branch__20241107092448 branch November 13, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheo89 atheo89 Awaiting requested review from atheo89

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees
No one assigned
Labels
needs-ok-to-test needs-rebase The PR needs a rebase or there are conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-merge-robot @atheo89 @jstourac @jiridanek