Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick a8da75c, f10945b and 0e775db #748

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

hbelmiro
Copy link
Contributor

hbelmiro and others added 3 commits November 13, 2024 18:16
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
(cherry picked from commit c4c8bc0)
(cherry picked from commit 0fc7597)
Signed-off-by: Helber Belmiro <helber.belmiro@gmail.com>
(cherry picked from commit 7b35ab5)
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rimolive for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsp-developers
Copy link
Contributor

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-748
An OCP cluster where you are logged in as cluster admin is required.

To use this image run the following:

cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/748/head
git checkout -b pullrequest 51277adb7cb480dd91940890fd46e59cc92513e2
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-748"

More instructions here on how to deploy and test a Data Science Pipelines Application.

@hbelmiro hbelmiro marked this pull request as ready for review November 13, 2024 21:39
@HumairAK HumairAK merged commit 145bf15 into opendatahub-io:stable Nov 13, 2024
5 of 6 checks passed
@hbelmiro hbelmiro deleted the RHOAIENG-15689-stable branch November 13, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants