Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DSPO test suite to KFP 2.10.0 #745

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

diegolovison
Copy link
Contributor

@diegolovison diegolovison commented Nov 13, 2024

The issue resolved by this Pull Request:

Resolves #RHOAIENG-15760

Description of your changes:

Bump KFP to 2.10.0. The tests that are using the pip server were downloaded 2.10.0 and the yaml has 2.9.0. Due to that the test simulates the air-gap environment. The test was failing.

I also changed the timeout. Sometimes it will take more than 10 seconds and iterating every 2ms is not feasible. Each operation take more time than that.

Testing instructions

NA

Checklist

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@diegolovison diegolovison force-pushed the doc3 branch 2 times, most recently from 061ac71 to cf3ffcc Compare November 13, 2024 19:28
@diegolovison diegolovison changed the title trigger gha Bump DSPO test suite to KFP 2.10.0 Nov 13, 2024
@diegolovison diegolovison marked this pull request as ready for review November 13, 2024 19:48
@openshift-ci openshift-ci bot requested review from HumairAK and rimolive November 13, 2024 19:48
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@HumairAK
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK HumairAK merged commit f10945b into opendatahub-io:main Nov 13, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants