Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goldfish-armeabi-v7a-ap-citest: Update INIT_STACKSIZE to 6144 #7

Conversation

JianyuWang0623
Copy link
Member

Summary

goldfish-armeabi-v7a-ap-citest: Update INIT_STACKSIZE to 6144.
Stack overflowed when size is 4096.
Mainly difference with "goldfish-armeabi-v7a-ap" is NSH_LINELEN=2048.

Impact

goldfish-armeabi-v7a-ap-citest

Testing

  1. Selftest with this patch
# Used: 0004104
openvela-ap> ps -heap
  PID GROUP PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK              HEAP   STACK    USED FILLED COMMAND
    0     0   0 FIFO     Kthread   - Ready              0000000000000000 00012288 0001968 0000896  45.5%  Idle_Task
    1     0 192 RR       Kthread   - Waiting  Semaphore 0000000000000000 00000000 0003968 0000464  11.6%  hpwork 0x402143ac 0x402143d0
    2     0 100 RR       Kthread   - Waiting  Semaphore 0000000000000000 00000000 0003968 0000448  11.2%  lpwork 0x40214374 0x40214398
    4     0 100 RR       Kthread   - Waiting  Signal    0000000000000000 00000000 0003968 0000496  12.5%  goldfish_gpu_fb_thread 0x4027a930
    5     0 100 RR       Kthread   - Waiting  Semaphore 0000000000000000 00000000 0003968 0000824  20.7%  goldfish_gnss_thread 0x406dad60
    6     0 100 RR       Kthread   - Waiting  Semaphore 0000000000000000 00000000 0003968 0000904  22.7%  goldfish_sensor_thread 0x402e88d0
    7     7 100 RR       Task      - Running            0000000000000000 00020560 0006040 0004104  67.9%  nsh_main
    9     9 100 RR       Task      - Waiting  Semaphore 0000000000000000 00033000 0004000 0001640  41.0%  kvdbd
   10    10 100 RR       Task      - Waiting  Semaphore 0000000000000000 00044752 0004000 0001848  46.2%  adbd
  1. CI

Stack overflowed when size is 4096.
Mainly difference with "goldfish-armeabi-v7a-ap" is `NSH_LINELEN=2048`.

With this patch

  # Used: 0004104
  openvela-ap> ps -heap
    PID GROUP PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK              HEAP   STACK    USED FILLED COMMAND
      0     0   0 FIFO     Kthread   - Ready              0000000000000000 00012288 0001968 0000896  45.5%  Idle_Task
      1     0 192 RR       Kthread   - Waiting  Semaphore 0000000000000000 00000000 0003968 0000464  11.6%  hpwork 0x402143ac 0x402143d0
      2     0 100 RR       Kthread   - Waiting  Semaphore 0000000000000000 00000000 0003968 0000448  11.2%  lpwork 0x40214374 0x40214398
      4     0 100 RR       Kthread   - Waiting  Signal    0000000000000000 00000000 0003968 0000496  12.5%  goldfish_gpu_fb_thread 0x4027a930
      5     0 100 RR       Kthread   - Waiting  Semaphore 0000000000000000 00000000 0003968 0000824  20.7%  goldfish_gnss_thread 0x406dad60
      6     0 100 RR       Kthread   - Waiting  Semaphore 0000000000000000 00000000 0003968 0000904  22.7%  goldfish_sensor_thread 0x402e88d0
      7     7 100 RR       Task      - Running            0000000000000000 00020560 0006040 0004104  67.9%  nsh_main
      9     9 100 RR       Task      - Waiting  Semaphore 0000000000000000 00033000 0004000 0001640  41.0%  kvdbd
     10    10 100 RR       Task      - Waiting  Semaphore 0000000000000000 00044752 0004000 0001848  46.2%  adbd

Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
@xiaoxiang781216
Copy link

let's continue apache/nuttx-apps#2918 and apache/nuttx#15326 to reduce the stack size.

@JianyuWang0623
Copy link
Member Author

let's continue apache/nuttx-apps#2918 and apache/nuttx#15326 to reduce the stack size.

get

@xiaoxiang781216 xiaoxiang781216 merged commit e4bc20c into open-vela:dev Jan 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants