-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nshlib/pipeline: Concat variable arguments failed #50
Merged
xiaoxiang781216
merged 1 commit into
open-vela:dev
from
JianyuWang0623:br_wjy_nsh_parse_concat_var_arg_failed_241112_openvela
Jan 13, 2025
Merged
nshlib/pipeline: Concat variable arguments failed #50
xiaoxiang781216
merged 1 commit into
open-vela:dev
from
JianyuWang0623:br_wjy_nsh_parse_concat_var_arg_failed_241112_openvela
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Without this patch nsh> set var_test `uname` nsh> echo $var_test NuttX nsh> echo $var_test | cat sh [5:100] nsh> 2. With this patch nsh> set var_test `uname` nsh> echo $var_test NuttX nsh> echo $var_test | cat sh [4:100] NuttX nsh> Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
nsh_execute()
xiaoxiang781216
approved these changes
Jan 11, 2025
[Fixed] The CI error before (without open-vela/vendor_openvela#7)
|
xiaoxiang781216
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pick from apache/nuttx-apps#2841
Concat variable arguments failed
Reported by @jasonbu and @yangao1@xiaomi.com, thank you ;-)
Impact
nshlib/pipeline
Testing